Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task json that accommodates on-cancel emergency lots #865

Merged
merged 6 commits into from
Jan 10, 2024

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Dec 26, 2023

What's new

  • emergencyLots added to resourceManager
  • updated task json for deliveries and custom deliveries

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 821 lines in your changes are missing coverage. Please review.

Comparison is base (fe0e808) 49.35% compared to head (b0ff4a5) 26.61%.
Report is 46 commits behind head on deploy/hammer.

Files Patch % Lines
packages/dashboard/src/components/map-app.tsx 0.00% 171 Missing ⚠️
.../dashboard/src/components/delivery-alert-store.tsx 0.00% 100 Missing ⚠️
...ackages/react-components/lib/tasks/create-task.tsx 0.00% 89 Missing ⚠️
packages/react-components/lib/tasks/utils.ts 4.76% 54 Missing and 6 partials ⚠️
packages/dashboard/src/components/door-summary.tsx 0.00% 51 Missing ⚠️
...kages/dashboard/src/components/tasks/tasks-app.tsx 0.00% 51 Missing ⚠️
...shboard/src/components/tasks/task-cancellation.tsx 0.00% 48 Missing ⚠️
packages/dashboard/src/components/lift-summary.tsx 0.00% 47 Missing ⚠️
packages/dashboard/src/components/appbar.tsx 36.36% 21 Missing ⚠️
...s/dashboard/src/components/tasks/task-schedule.tsx 0.00% 20 Missing ⚠️
... and 25 more
Additional details and impacted files
@@                Coverage Diff                 @@
##           deploy/hammer     #865       +/-   ##
==================================================
- Coverage          49.35%   26.61%   -22.74%     
==================================================
  Files                285      157      -128     
  Lines               7564     5223     -2341     
  Branches            1050     1339      +289     
==================================================
- Hits                3733     1390     -2343     
+ Misses              3682     3634       -48     
- Partials             149      199       +50     
Flag Coverage Δ
api-server ?
dashboard 13.80% <3.68%> (-1.27%) ⬇️
react-components 43.88% <15.70%> (-4.20%) ⬇️
rmf-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth marked this pull request as ready for review December 26, 2023 14:14
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth merged commit fbf06a4 into deploy/hammer Jan 10, 2024
3 of 4 checks passed
@aaronchongth aaronchongth deleted the hammer/on-cancel branch January 10, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant