Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert all dashboard-e2e packages #867

Merged
merged 10 commits into from
Jan 2, 2024

Conversation

aaronchongth
Copy link
Member

What's new

  • Fix e2e

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e53e232) 44.08% compared to head (aa97c07) 44.14%.

❗ Current head aa97c07 differs from pull request most recent head f731ade. Consider uploading reports for the commit f731ade to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                  @@
##           hammer/bump-node     #867      +/-   ##
====================================================
+ Coverage             44.08%   44.14%   +0.06%     
====================================================
  Files                   264      264              
  Lines                  7847     7835      -12     
  Branches               1218     1216       -2     
====================================================
  Hits                   3459     3459              
+ Misses                 4232     4220      -12     
  Partials                156      156              
Flag Coverage Δ
dashboard 14.19% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth marked this pull request as ready for review January 2, 2024 05:39
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth merged commit e3859fb into hammer/bump-node Jan 2, 2024
2 checks passed
@aaronchongth aaronchongth deleted the hammer/bump-node-fix-e2e branch January 2, 2024 06:20
aaronchongth added a commit that referenced this pull request Jan 3, 2024
* Node 18.19.0, pnpm i -g pnpm, pnpm up -r -L

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Removed workcells

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Removed unused map components

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Remove leaflet

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Migrated datagrid props

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Updated lock file

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Migrated create task

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Using node 18

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Removed types/react-leaflet

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert trajectory data

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Remove dashboard leaflet overlays

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Remove leaflet from css and tests

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Add required scale to resource manager

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Regenerated api-client

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Do not generate sourcemap to skip error

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Dashboard build issues

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* rmf-auth, TODO login stories, add new to keycloak creation

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint and test fixing for react-components

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* react-components, lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fixing storybook

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* react-components, using default storybook webpack config, cleaned up commented debugs

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Use dev ci mode for storybook

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Not build storybook in ci for react-components for now

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Reverted axios to lower version to prevent axios.request is not a function issue, axios#5038

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* rmf-auth, install missing jest-environment-jsdom for tests

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Bump dashboard axios version, fix axios API

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* dashboard, updated tests, remove use of waitForElementToBeRemoved (react-testing-library#1033)

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Commit package-lock back even though unused, to keep diff small

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* react-components, revert karma-chrome-launcher version

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* react-components, missing pnpm-lock change for karma-chrome-launcher reversion

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Hammer/kc23 auth (#864)

* Log all verification information used

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Logging in rmf-auth

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix typo

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Handle axios request and response, refresh token with 30 seconds interval

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert pyright version

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Cleaned up stale commented code

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix rmf-auth storybook

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Allow generating sourcemap

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Retry on chrome launcher

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* run retrying command only wihtint react-components

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert to running basic test coverage

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix for puppeteer default cache directory

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Call puppeteer install manually before running test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert to basic run to try again

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Puppeteerrc at root of project

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert config, add build step that is removed from commented storybook ci step

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* With additional install step

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Explicit build step

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert version of puppeteer

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Bump puppeteer to non-EOL version

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Bumping puppeteer to 20.9.0

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Bump puppeteer to 21.6.1

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Build hammer overlay

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert chalk version

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Remove use of overlay workspaces, since changes have been merged

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert inquirer version

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Change API call for newer concurrently version

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert version of concurrently in dashboard-e2e

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix TextField background theme

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert version for browserstack and wdio packages

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert all dashboard-e2e packages (#867)

* Revert all dashboard-e2e packages

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Splitting up build:test and start:test for e2e, only retry start:test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Check if build exists to start build again instead

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert e2e task submission tests to patrol tasks

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Remove resolution alerts

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Disabling e2e tests on safari for now, testing on chrome and edge

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Running firefox for e2e too

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Only testing on Windows 10

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert commented resolution alert

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert jasmine and ts-node versions (#868)

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant