-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api-server] fix typings, update dependencies #886
Conversation
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #886 +/- ##
==========================================
- Coverage 51.51% 50.48% -1.04%
==========================================
Files 282 283 +1
Lines 7159 7179 +20
Branches 960 960
==========================================
- Hits 3688 3624 -64
- Misses 3323 3407 +84
Partials 148 148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling this! Just did a quick review, and things look good so far since there're not really any behavioral changes
Moving forwards, should we be avoiding any use of typing
(where possible), and try to stick to python's base types?
I did notice that the door and lift app is broken now, probably due to model changes. You can check by navigating to localhost:3000/robots
Yeah in general we should aim for that, but in practice it may be hard so I think it's not something that we need to enforce.
Thanks for pointing out, I will look into it. |
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay! Thanks for the fix, I don't see any issues running through sim
What's new
rxpy
(now calledreactivex
) to improve typingstortoise-orm and pydantic are pretty outdated as well. We should look into updating them soon.
Self-checks
Discussion