Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix missing binding for Segment::Solution #253

Merged

Conversation

vishwa2710
Copy link
Contributor

No description provided.

@vishwa2710 vishwa2710 requested a review from apaletta3 October 17, 2023 15:53
@vishwa2710 vishwa2710 self-assigned this Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #253 (e0719d9) into main (d4aae19) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   83.50%   83.50%           
=======================================
  Files          66       66           
  Lines        5546     5548    +2     
=======================================
+ Hits         4631     4633    +2     
  Misses        915      915           
Files Coverage Δ
...nSpaceToolkit/Astrodynamics/Trajectory/Segment.hpp 100.00% <ø> (ø)
...nSpaceToolkit/Astrodynamics/Trajectory/Segment.cpp 98.92% <100.00%> (+0.02%) ⬆️

@vishwa2710 vishwa2710 enabled auto-merge (squash) October 17, 2023 16:30
Copy link
Contributor

@apaletta3 apaletta3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Made just one comment, feel free to implement or not.

@vishwa2710 vishwa2710 merged commit 8907f7d into main Oct 17, 2023
12 checks passed
@vishwa2710 vishwa2710 deleted the users/vishwa/fix-segment-solution-get-propagation-duration branch October 17, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants