Skip to content

chore: add tests for Scalar, Vector and Direction #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 24, 2024

Conversation

vishwa2710
Copy link
Contributor

No description provided.

@vishwa2710 vishwa2710 requested a review from apaletta3 February 17, 2024 10:42
@vishwa2710 vishwa2710 self-assigned this Feb 17, 2024
@vishwa2710 vishwa2710 force-pushed the chore/add-test-for-data branch from e9f5a6f to 7193b1f Compare February 20, 2024 01:22
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.31%. Comparing base (4e0768b) to head (e0e5141).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   79.60%   80.31%   +0.70%     
==========================================
  Files          96       97       +1     
  Lines        7542     7537       -5     
==========================================
+ Hits         6004     6053      +49     
+ Misses       1538     1484      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apaletta3 apaletta3 force-pushed the chore/add-test-for-data branch from 7193b1f to 521554b Compare February 23, 2024 13:13
Copy link
Contributor

@apaletta3 apaletta3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking care of this! Just approve nits if you agree :)

Co-authored-by: Antoine Paletta <98616558+apaletta3@users.noreply.github.com>
@vishwa2710 vishwa2710 enabled auto-merge (squash) February 24, 2024 10:15
@vishwa2710 vishwa2710 disabled auto-merge February 24, 2024 10:59
@vishwa2710 vishwa2710 merged commit d867401 into main Feb 24, 2024
@vishwa2710 vishwa2710 deleted the chore/add-test-for-data branch February 24, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants