[receiver/datadog] Add initial support for metrics #33631

carrieedwards · 2024-06-18T15:20:03Z

Description:
This PR adds the initial structure required to add support for metrics in the Datadog receiver. This is the first of several PRs which will add support for v1 and v2 series endpoints, service checks, as well as sketches.

The full version of the code can be found in the cedwards/datadog-metrics-receiver-full branch, or in Grafana Alloy: https://github.com/grafana/alloy/tree/main/internal/etc/datadogreceiver

Link to tracking Issue:
#18278

Testing:
Unit tests have been added. More thorough tests will be included in follow-up PRs as the remaining functionality is added.

Documentation:
Updated README

carrieedwards · 2024-06-18T15:30:51Z

Holding off on rebasing until the after the release

jpkrohling

This is a great start, thank you! Let's wait until the release is done and see if we have further reviews until then.

jpkrohling · 2024-06-19T05:38:57Z

receiver/datadogreceiver/receiver.go

@@ -109,3 +133,87 @@ func (ddr *datadogReceiver) handleTraces(w http.ResponseWriter, req *http.Reques
 	_, _ = w.Write([]byte("OK"))

 }
+
+// handleV1Series handles the v1 series endpoint https://docs.datadoghq.com/api/latest/metrics/#submit-metrics
+func (ddr *datadogReceiver) handleV1Series(w http.ResponseWriter, req *http.Request) {


Perhaps not for this PR, but it might be a good idea to split the handlers in their own source file.

Do you mean something like metrics_receiver.go and traces_receiver.go?

That too, but what I had in mind was splitting the handlers themselves into separate files, keeping only references to them on the receiver code.

receiver/datadogreceiver/httpmetrics.go

MovieStoreGuy

This looks like a great start.

MovieStoreGuy · 2024-06-21T02:08:28Z

receiver/datadogreceiver/receiver.go

@@ -109,3 +133,87 @@ func (ddr *datadogReceiver) handleTraces(w http.ResponseWriter, req *http.Reques
 	_, _ = w.Write([]byte("OK"))

 }
+
+// handleV1Series handles the v1 series endpoint https://docs.datadoghq.com/api/latest/metrics/#submit-metrics
+func (ddr *datadogReceiver) handleV1Series(w http.ResponseWriter, req *http.Request) {


Do you mean something like metrics_receiver.go and traces_receiver.go?

**Description**: This PR is a follow up to the former #33631 extending the existing tags translation structure. This will be required for the follow up PRs adding support for v1 and v2 series endpoints, service checks, as well as sketches. The full version of the code can be found in the cedwards/datadog-metrics-receiver-full branch, or in Grafana Alloy: https://github.com/grafana/alloy/tree/main/internal/etc/datadogreceiver **Link to tracking Issue:** #18278 **Testing**: Unit tests have been added. More thorough tests will be included in follow-up PRs as the remaining functionality is added. **Notes**: - Adding `[chore]` to the title of the PR because https://github.com/grafana/opentelemetry-collector-contrib/blob/ab4d726aaaa07aad702ff3b312a8e261f2b38021/.chloggen/datadogreceiver_metrics.yaml#L1-L27 already exists. --------- Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

**Description:** This PR adds support for V1 series, as well as batches the metrics by resource, scope, and datapoint attributes. The batching code will also be required for future PRs which will add support for v2 series endpoints, service checks, and sketches. Follow up of #33631 and #33922. The full version of the code can be found in the `cedwards/datadog-metrics-receiver-full` branch, or in Grafana Alloy: https://github.com/grafana/alloy/tree/main/internal/etc/datadogreceiver **Link to tracking Issue:** #18278 **Testing:** Unit tests, as well as an end-to-end test, have been added. --------- Co-authored-by: Federico Torres <federico.sa.torres@gmail.com>

**Description:** This PR adds support for Datadog V2 series. Follow up of #33631 and #33957. The full version of the code can be found in the `cedwards/datadog-metrics-receiver-full` branch, or in Grafana Alloy: https://github.com/grafana/alloy/tree/main/internal/etc/datadogreceiver **Link to tracking Issue:** #18278 **Testing:** Unit tests, as well as an end-to-end test, have been added.

Description: This PR adds support for Datadog Service Checks. Follow up of #33631 , #33957 and #34180. The full version of the code can be found in the cedwards/datadog-metrics-receiver-full branch, or in Grafana Alloy: https://github.com/grafana/alloy/tree/main/internal/etc/datadogreceiver Link to tracking Issue: #18278 Testing: Unit tests, as well as an end-to-end test, have been added. --------- Signed-off-by: alexgreenbank <alex.greenbank@grafana.com> Co-authored-by: Carrie Edwards <edwrdscarrie@gmail.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>

**Description:** This PR adds support for translating Datadog sketches into Exponential Histograms. Follow up of #33631, #33957 and #34180. The full version of the code can be found in the `cedwards/datadog-metrics-receiver-full` branch, or in Grafana Alloy: https://github.com/grafana/alloy/tree/main/internal/etc/datadogreceiver **Link to tracking Issue:** #18278 **Testing:** Unit tests, as well as an end-to-end test, have been added. --------- Signed-off-by: Federico Torres <federico.torres@grafana.com> Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Co-authored-by: Federico Torres <federico.sa.torres@gmail.com> Co-authored-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>

…34180) **Description:** This PR adds support for Datadog V2 series. Follow up of open-telemetry#33631 and open-telemetry#33957. The full version of the code can be found in the `cedwards/datadog-metrics-receiver-full` branch, or in Grafana Alloy: https://github.com/grafana/alloy/tree/main/internal/etc/datadogreceiver **Link to tracking Issue:** open-telemetry#18278 **Testing:** Unit tests, as well as an end-to-end test, have been added.

…etry#34474) Description: This PR adds support for Datadog Service Checks. Follow up of open-telemetry#33631 , open-telemetry#33957 and open-telemetry#34180. The full version of the code can be found in the cedwards/datadog-metrics-receiver-full branch, or in Grafana Alloy: https://github.com/grafana/alloy/tree/main/internal/etc/datadogreceiver Link to tracking Issue: open-telemetry#18278 Testing: Unit tests, as well as an end-to-end test, have been added. --------- Signed-off-by: alexgreenbank <alex.greenbank@grafana.com> Co-authored-by: Carrie Edwards <edwrdscarrie@gmail.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>

**Description:** This PR adds support for translating Datadog sketches into Exponential Histograms. Follow up of open-telemetry#33631, open-telemetry#33957 and open-telemetry#34180. The full version of the code can be found in the `cedwards/datadog-metrics-receiver-full` branch, or in Grafana Alloy: https://github.com/grafana/alloy/tree/main/internal/etc/datadogreceiver **Link to tracking Issue:** open-telemetry#18278 **Testing:** Unit tests, as well as an end-to-end test, have been added. --------- Signed-off-by: Federico Torres <federico.torres@grafana.com> Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Co-authored-by: Federico Torres <federico.sa.torres@gmail.com> Co-authored-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>

…etry#34474) Description: This PR adds support for Datadog Service Checks. Follow up of open-telemetry#33631 , open-telemetry#33957 and open-telemetry#34180. The full version of the code can be found in the cedwards/datadog-metrics-receiver-full branch, or in Grafana Alloy: https://github.com/grafana/alloy/tree/main/internal/etc/datadogreceiver Link to tracking Issue: open-telemetry#18278 Testing: Unit tests, as well as an end-to-end test, have been added. --------- Signed-off-by: alexgreenbank <alex.greenbank@grafana.com> Co-authored-by: Carrie Edwards <edwrdscarrie@gmail.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>

**Description:** This PR adds support for translating Datadog sketches into Exponential Histograms. Follow up of open-telemetry#33631, open-telemetry#33957 and open-telemetry#34180. The full version of the code can be found in the `cedwards/datadog-metrics-receiver-full` branch, or in Grafana Alloy: https://github.com/grafana/alloy/tree/main/internal/etc/datadogreceiver **Link to tracking Issue:** open-telemetry#18278 **Testing:** Unit tests, as well as an end-to-end test, have been added. --------- Signed-off-by: Federico Torres <federico.torres@grafana.com> Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Co-authored-by: Federico Torres <federico.sa.torres@gmail.com> Co-authored-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>

carrieedwards requested a review from a team June 18, 2024 15:20

carrieedwards requested review from jpkrohling and MovieStoreGuy as code owners June 18, 2024 15:20

github-actions bot assigned evan-bradley Jun 18, 2024

github-actions bot added receiver/datadog testbed labels Jun 18, 2024

github-actions bot requested review from boostchicken and gouthamve June 18, 2024 15:20

jpkrohling reviewed Jun 19, 2024

View reviewed changes

carrieedwards force-pushed the cedwards/datadog-metrics-receiver branch 2 times, most recently from a005ecc to f73d2c9 Compare June 20, 2024 16:22

MovieStoreGuy reviewed Jun 21, 2024

View reviewed changes

github-actions bot added the exporter/elasticsearch label Jun 21, 2024

github-actions bot requested review from carsonip, JaredTan95 and ycombinator June 21, 2024 15:41

carrieedwards added 5 commits July 2, 2024 11:08

Add initial support for metrics in Datadog receiver

c0f2bde

Fix lint failures

6151c83

Remove unnecessary telemetry

e0be7f2

Update go.mod

3e97bd1

Update vendoring

fbf713a

carrieedwards force-pushed the cedwards/datadog-metrics-receiver branch from c7dc27e to fbf713a Compare July 2, 2024 18:24

Merge branch 'main' into cedwards/datadog-metrics-receiver

d3694a3

jpkrohling approved these changes Jul 3, 2024

View reviewed changes

jpkrohling merged commit ab4d726 into open-telemetry:main Jul 3, 2024
154 checks passed

github-actions bot added this to the next release milestone Jul 3, 2024

jesusvazquez mentioned this pull request Jul 4, 2024

[chore]: datadog receiver: Tags translation #33922

Merged

carrieedwards mentioned this pull request Jul 9, 2024

[chore] [receiver/datadog] Add support for v1 series #33957

Merged

carrieedwards mentioned this pull request Jul 19, 2024

[chore] [receiver/datadog] Add support for v2 series #34180

Merged

alexgreenbank mentioned this pull request Aug 7, 2024

[chore] [receiver/datadog] Add support for Service Checks #34474

Merged

carrieedwards mentioned this pull request Aug 13, 2024

[receiver/datadog] Add support for sketches #34662

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[receiver/datadog] Add initial support for metrics #33631

[receiver/datadog] Add initial support for metrics #33631

carrieedwards commented Jun 18, 2024 •

edited

Loading

carrieedwards commented Jun 18, 2024

jpkrohling left a comment •

edited

Loading

jpkrohling Jun 19, 2024

MovieStoreGuy Jun 21, 2024

jpkrohling Jul 3, 2024

MovieStoreGuy left a comment

MovieStoreGuy Jun 21, 2024

[receiver/datadog] Add initial support for metrics #33631

[receiver/datadog] Add initial support for metrics #33631

Conversation

carrieedwards commented Jun 18, 2024 • edited Loading

carrieedwards commented Jun 18, 2024

jpkrohling left a comment • edited Loading

Choose a reason for hiding this comment

jpkrohling Jun 19, 2024

Choose a reason for hiding this comment

MovieStoreGuy Jun 21, 2024

Choose a reason for hiding this comment

jpkrohling Jul 3, 2024

Choose a reason for hiding this comment

MovieStoreGuy left a comment

Choose a reason for hiding this comment

MovieStoreGuy Jun 21, 2024

Choose a reason for hiding this comment

carrieedwards commented Jun 18, 2024 •

edited

Loading

jpkrohling left a comment •

edited

Loading