[exporter/elasticsearch] Limit bulk request size to avoid 413 Entity Too Large #36396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonip
changed the title
flush::bytes
carsonip
changed the title
flush::bytesflush::bytes in sync bulk indexer
|
Also benched with ~5MB vs ~1MB vs 95MB flush::bytes to an Elastic Cloud 64GB Elasticsearch, with num_workers=1: 5MB: 1MB: 95MB: |
carsonip
changed the title
flush::bytes in sync bulk indexer
lahsivjar
reviewed
Nov 20, 2024
ChrsMark
approved these changes
Nov 21, 2024
| }, | ||
| }, | ||
| Flush: FlushSettings{ | ||
| Bytes: 5e+6, |
There was a problem hiding this comment.
nit: maybe consider moving these defaults to some constant vars at some point. (not for this PR)
ChrsMark
added
the
ready to merge
Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
mauri870
added a commit
to mauri870/beats
that referenced
this pull request
Dec 5, 2024
This code was initially added in elastic#41523 because of a limitation from the elasticsearch exporter. The elasticsearch exporter has been updated to enforce flush::max_bytes for the batcher extension and will automatically split the batch if it exceeds the limit. This error is now fixed in the collector v0.115.0. See open-telemetry/opentelemetry-collector-contrib#36396.
6 tasks
mauri870
added a commit
to elastic/beats
that referenced
this pull request
Dec 10, 2024
This code was initially added in #41523 because of a limitation from the elasticsearch exporter. The elasticsearch exporter has been updated to enforce flush::max_bytes for the batcher extension and will automatically split the batch if it exceeds the limit. This error is now fixed in the collector v0.115.0. See open-telemetry/opentelemetry-collector-contrib#36396.
mergify bot
pushed a commit
to elastic/beats
that referenced
this pull request
Dec 10, 2024
This code was initially added in #41523 because of a limitation from the elasticsearch exporter. The elasticsearch exporter has been updated to enforce flush::max_bytes for the batcher extension and will automatically split the batch if it exceeds the limit. This error is now fixed in the collector v0.115.0. See open-telemetry/opentelemetry-collector-contrib#36396. (cherry picked from commit dbeb9cd)
6 tasks
mauri870
added a commit
to elastic/beats
that referenced
this pull request
Dec 10, 2024
…41971) This code was initially added in #41523 because of a limitation from the elasticsearch exporter. The elasticsearch exporter has been updated to enforce flush::max_bytes for the batcher extension and will automatically split the batch if it exceeds the limit. This error is now fixed in the collector v0.115.0. See open-telemetry/opentelemetry-collector-contrib#36396. (cherry picked from commit dbeb9cd) Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
michalpristas
pushed a commit
to michalpristas/beats
that referenced
this pull request
Dec 13, 2024
…41911) This code was initially added in elastic#41523 because of a limitation from the elasticsearch exporter. The elasticsearch exporter has been updated to enforce flush::max_bytes for the batcher extension and will automatically split the batch if it exceeds the limit. This error is now fixed in the collector v0.115.0. See open-telemetry/opentelemetry-collector-contrib#36396.
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…Too Large (open-telemetry#36396) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Limit the bulk request size to roughly `flush::bytes` for sync bulk indexer. Sync bulk indexer is used when `batcher::enabled` is either true or false. In order words, sync bulk indexer is not used when batcher config is undefined. Change `flush::bytes` to always measure in uncompressed bytes. Change default `batcher::max_size_items` to `0` as bulk request size limit is now more effectively enforced by `flush::bytes`. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36163 <!--Describe what testing was performed and which tests were added.--> #### Testing Modified BenchmarkExporter to run with `{name: "xxlarge_batch", batchSize: 1000000},` and removed `batcher::max_size_items` and added a log line for compressed and uncompressed buffer size to reproduce the error. ``` logger.go:146: 2024-11-19T17:16:40.060Z ERROR Flush {"s.bi.Len": 10382932, "s.bi.UncompressedLen": 532777786} logger.go:146: 2024-11-19T17:16:40.312Z ERROR bulk indexer flush error {"error": "flush failed (413): [413 Request Entity Too Large] "} ``` With this PR, every flush logs and there is no error. ``` logger.go:146: 2024-11-19T17:23:52.574Z ERROR Flush {"s.bi.Len": 99148, "s.bi.UncompressedLen": 5000007} ``` <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Limit the bulk request size to roughly
flush::bytesfor sync bulk indexer.Sync bulk indexer is used when
batcher::enabledis either true or false. In order words, sync bulk indexer is not used when batcher config is undefined.Change
flush::bytesto always measure in uncompressed bytes.Change default
batcher::max_size_itemsto0as bulk request size limit is now more effectively enforced byflush::bytes.Link to tracking issue
Fixes #36163
Testing
Modified BenchmarkExporter to run with
{name: "xxlarge_batch", batchSize: 1000000},and removedbatcher::max_size_itemsand added a log line for compressed and uncompressed buffer size to reproduce the error.With this PR, every flush logs and there is no error.
Documentation