Remove experimental methods out of (to-be-public) TelemetryBuilder classes #12847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
trask
force-pushed
the
move-experimental-out-of-public-api
branch
from
a72ae3f to
0cff2dd
Compare
trask
changed the title
emitExperimentalHttpClientMetrics methods out of (to-be-public) TelemetryBuilder classes
12 tasks
trask
force-pushed
the
move-experimental-out-of-public-api
branch
from
0cff2dd to
2e7512c
Compare
trask
force-pushed
the
move-experimental-out-of-public-api
branch
from
2e7512c to
a2b128f
Compare
trask
changed the title
emitExperimentalHttpClientMetrics methods out of (to-be-public) TelemetryBuilder classes
This was referenced Dec 8, 2024
trask
force-pushed
the
move-experimental-out-of-public-api
branch
2 times, most recently
from
39a22aa to
ce4bd9b
Compare
trask
force-pushed
the
move-experimental-out-of-public-api
branch
from
ce4bd9b to
eed12e5
Compare
This was referenced Dec 9, 2024
trask
commented
Dec 9, 2024
Comment on lines
35
to
45
| /** | ||
| * @deprecated Use {@link Experimental#setEmitExperimentalTelemetry(NettyClientTelemetryBuilder, | ||
| * boolean)} instead. | ||
| */ | ||
| @Deprecated | ||
| @CanIgnoreReturnValue | ||
| public NettyClientTelemetryBuilder setEmitExperimentalHttpClientEvents( | ||
| boolean emitExperimentalHttpClientEvents) { | ||
| this.emitExperimentalHttpClientEvents = emitExperimentalHttpClientEvents; | ||
| boolean emitExperimentalTelemetry) { | ||
| this.emitExperimentalTelemetry = emitExperimentalTelemetry; | ||
| return this; | ||
| } |
There was a problem hiding this comment.
I combined this with emitExperimentalTelemetry, which matches how it's enabled under single java agent flag otel.instrumentation.http.client.emit-experimental-telemetry
zeitlinger
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setEmitExperimental*methods in*TelemetryBuilderclasses have been deprecated and moved to internal/experimental classes, see Javadoc@deprecatedfor exact relocationPart of #12846
See #12867 for change log migration notes entry