Split Webflux into client and server #12852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
12 tasks
trask
force-pushed
the
split-webflux
branch
2 times, most recently
from
79beda9 to
15400e8
Compare
trask
force-pushed
the
split-webflux
branch
4 times, most recently
from
6679d4f to
de56007
Compare
laurit
reviewed
Dec 11, 2024
| import org.springframework.web.reactive.function.client.ExchangeFilterFunction; | ||
|
|
||
| /** Entrypoint for instrumenting Spring Webflux HTTP clients. */ | ||
| public final class SpringWebfluxClientTelemetry { |
There was a problem hiding this comment.
same question as with armeria, do we want client and server instrumentation in separate packages as with ktor
laurit
reviewed
Dec 11, 2024
...o/opentelemetry/instrumentation/spring/webflux/v5_3/SpringWebfluxClientTelemetryBuilder.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Dec 11, 2024
...o/opentelemetry/instrumentation/spring/webflux/v5_3/SpringWebfluxServerTelemetryBuilder.java
Outdated
Show resolved
Hide resolved
trask
commented
Dec 11, 2024
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.instrumentation.spring.webflux.old.v5_3; |
There was a problem hiding this comment.
I had to move this to a non-conflicting package so both @SpringBootApplication classes wouldn't be seen and conflict
laurit
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpringWebfluxTelemetry*classes have been deprecated and split intoSpringWebfluxClientTelemetry*andSpringWebfluxServerTelemetry*Part of #12846
See #12867 for change log migration notes entry