Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link in Deno instructions for operator #5993

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Fix link in Deno instructions for operator #5993

merged 3 commits into from
Jan 21, 2025

Conversation

lucacasonato
Copy link
Contributor

No description provided.

@lucacasonato lucacasonato requested a review from a team as a code owner January 20, 2025 17:36
@opentelemetrybot opentelemetrybot requested a review from a team January 20, 2025 17:36
@lucacasonato lucacasonato mentioned this pull request Jan 20, 2025
Merged
chalin
chalin reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh, our markdown linter is complaining. Could you rename deno-otel-docs to maybe just deno-docs since the definition is local to the alert anyway?

@chalin chalin force-pushed the deno_operator_docs_followup branch from 28def28 to bd2ca24 Compare January 20, 2025 22:52
@chalin
Copy link
Contributor

chalin commented Jan 20, 2025

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12876812228

@opentelemetrybot
Copy link
Collaborator

fix:format was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@chalin
Copy link
Contributor

chalin commented Jan 20, 2025

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12876851482

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

chalin
chalin approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Given that this is a simply markdown fix, I'm going to merge.

image

@chalin chalin merged commit ed7630d into open-telemetry:main Jan 21, 2025
5 checks passed
@chalin
Copy link
Contributor

chalin commented Jan 21, 2025

Thanks @lucacasonato 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
sig:operator
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacasonato @chalin @opentelemetrybot