feat: add BitVec.toInt_sub #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires us to expand the theory of `Int.bmod`, add `Int.natCast_sub`, as well as `Int.ofNat_sub_ofNat` and a couple of related theorems.
tobiasgrosser
force-pushed
the
toInt_sub
branch
from
08a460b to
2f5ce55
Compare
tobiasgrosser
commented
Oct 19, 2024
| · norm_cast | ||
| simp_all | ||
| rw [← BitVec.zero_sub, toInt_sub] | ||
| simp [BitVec.toInt_ofNat] |
There was a problem hiding this comment.
How nice. Thank you, @alexkeizer.
Co-authored-by: Alex Keizer <alex@keizer.dev>
|
This has been meanwhile upstreamed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.