feat: toNat and toInt theorems for signExtend
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bollu
reviewed
Oct 27, 2024
|
Hmm, the CODEOWNERS file seems to be pinging me for reviews to this repo. Am I right in assuming I should ignore these until they appear on the main repo? |
|
Yes, we should probably use draft PRs here as well to avoid the pings. We are trying to first do an internal round of reviews, to maximize the quality of PRs for which we use your review bandwidth. |
mhk119
changed the title
toNat theorems for signExtendtoNat and toInt theorems for signExtend
This PR adds toNat and toInt theorems for BitVec.signExtend. Co-authored-by: Siddharth Bhat <siddu.druid@gmail.com> Co-authored-by: Harun Khan <harun19@stanford.edu>
|
Done! This has been upstreamed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.