Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [FC-0044] Course unit - Edit iframe modal window #35777

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Nov 5, 2024

🚨 Dependencies:

Description

This PR adds logic to support the functionality of editing xblocks via the legacy modal editing window.

Useful information to include:

  • Communication between the Backbone.js and the React app is done via post messages.
  • xBlock resources (CSS, JS files) are passed to the legacy modal edit window template.
  • Added some styles for xblock legacy modal content.

Supporting information

The next PR will be adding post messages for the tagging functionality.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 5, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 5, 2024

Thanks for the pull request, @PKulkoRaccoonGang!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft November 5, 2024 15:34
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/advanced_blocks_edit_and_move_modals branch 2 times, most recently from b64202e to 0e6e817 Compare November 5, 2024 18:27
@PKulkoRaccoonGang PKulkoRaccoonGang self-assigned this Nov 5, 2024
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/advanced_blocks_edit_and_move_modals branch from 8a6b032 to 74ac804 Compare November 6, 2024 17:40
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/advanced_blocks_edit_and_move_modals branch from 00886d4 to efccc8a Compare February 13, 2025 06:34
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/advanced_blocks_edit_and_move_modals branch from efccc8a to 362e883 Compare February 13, 2025 06:46
cms/static/cms/js/main.js Outdated Show resolved Hide resolved
cms/static/js/views/pages/container_subviews.js Outdated Show resolved Hide resolved
cms/static/sass/course-unit-mfe-iframe-bundle.scss Outdated Show resolved Hide resolved
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: In Eng Review
Development

Successfully merging this pull request may close these issues.

5 participants