feat: [FC-0070] handled edit modals from advanced xblocks #1445

PKulkoRaccoonGang · 2024-10-29T08:11:29Z

🚨 Dependencies:

🔗 edx-plarform PR

Description

This PR includes adding new message types, updating message handlers, and implementing a new modal iframe for legacy XBlock editing.

Supporting information

The next PR will be adding post messages for the tagging functionality.

Testing instructions

Screen.Recording.2025-02-17.at.09.56.38.mov

Other information

Settings

EDX_PLATFORM_REPOSITORY: https://github.com/raccoongang/edx-platform.git
EDX_PLATFORM_VERSION: Peter_Kulko/advanced_blocks_edit_and_move_modals

TUTOR_GROVE_NEW_MFES:
  authoring:
    port: 18000
    repository: https://github.com/raccoongang/frontend-app-course-authoring.git
    version: Peter_Kulko/edit-modal-for-advanced-xblocks

TUTOR_GROVE_WAFFLE_FLAGS:
  - name: contentstore.new_studio_mfe.use_new_unit_page
    everyone: true

TUTOR_GROVE_MFE_LMS_COMMON_SETTINGS:
  MFE_CONFIG:
    ENABLE_UNIT_PAGE: true

openedx-webhooks · 2024-10-29T08:11:34Z

Thanks for the pull request, @PKulkoRaccoonGang!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

bradenmacdonald · 2024-11-08T22:28:57Z

src/generic/modal-iframe/ModalIframe.tsx

+].join(' ');
+
+export const IFRAME_FEATURE_POLICY = (
+  'microphone *; camera *; midi *; geolocation *; encrypted-media *, clipboard-write *'


This has a typo - see openedx/frontend-app-learning#1500

Also, the same code in frontend-app-learning has this important notice which seems like it should be here too:

https://github.com/openedx/frontend-app-learning/blob/0effb3231831ef54eb5951d3bfa85d4975989605/src/courseware/course/sequence/Unit/ContentIFrame.jsx#L12-L23

codecov · 2025-02-13T07:43:28Z

Codecov Report

Attention: Patch coverage is 93.47826% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.30%. Comparing base (e9130d3) to head (9901401).
Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
src/course-unit/data/thunk.js	72.72%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1445      +/-   ##
==========================================
- Coverage   93.30%   93.30%   -0.01%     
==========================================
  Files        1101     1102       +1     
  Lines       21856    21899      +43     
  Branches     4645     4729      +84     
==========================================
+ Hits        20393    20433      +40     
+ Misses       1398     1395       -3     
- Partials       65       71       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

open-craft-grove · 2025-02-13T11:29:14Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-02-13T14:56:32Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

src/course-unit/xblock-container-iframe/hooks/useMessageHandlers.tsx

src/course-unit/xblock-container-iframe/utils.ts

src/generic/modal-iframe/index.tsx

open-craft-grove · 2025-02-17T09:31:29Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-02-17T09:52:46Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

PKulkoRaccoonGang · 2025-02-17T12:19:58Z

@arbrandes I have not been able to reproduce these issues. Could you please confirm if you are still experiencing them?
#1544 (review)

open-craft-grove · 2025-02-17T17:49:36Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-02-17T17:56:37Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

arbrandes · 2025-02-18T09:51:39Z

@PKulkoRaccoonGang, it seems the sandbox was not configured to deploy with the edx-platform PR branch it's supposed to depend on. Can you confirm?

PKulkoRaccoonGang · 2025-02-18T11:01:08Z

@arbrandes Yes, a few days ago I tried to do it from the correct branches (related to this PR), but it didn't work. Then I tried to check if the deployment from the master branches would be successful, the result was still unsuccessful.
It seems that the sandbox worked yesterday. Restarted the sandbox deployment

UPD: Sandbox deployment successful 🚀

open-craft-grove · 2025-02-18T12:04:02Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

arbrandes · 2025-02-18T16:19:28Z

I can't access the sandbox to test. I have asked @kaustavb12 to take a figure out if it's a deployment issue.

PKulkoRaccoonGang · 2025-02-19T08:28:41Z

@arbrandes I can log into the Studio in the deployed sandbox. Maybe try to log in via a direct link.
https://app.pr-1445-ba9a65.sandboxes.opencraft.hosting/authoring/course/course-v1:Test+123+2024

arbrandes

I could find nothing to object to in the code, and things work well as far as I was able to test them. Approved!

See openedx/edx-platform#35777 (review) for more review comments, as I tested both PRs simultaneously.

PKulkoRaccoonGang requested a review from a team as a code owner October 29, 2024 08:11

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 29, 2024

PKulkoRaccoonGang marked this pull request as draft October 29, 2024 08:11

mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Oct 29, 2024

PKulkoRaccoonGang self-assigned this Nov 5, 2024

PKulkoRaccoonGang force-pushed the Peter_Kulko/edit-modal-for-advanced-xblocks branch 2 times, most recently from f6b4000 to 648e1ae Compare November 6, 2024 17:43

bradenmacdonald reviewed Nov 8, 2024

View reviewed changes

bradenmacdonald mentioned this pull request Nov 8, 2024

Discovery: Editing other types of XBlocks #1201

Open

ihor-romaniuk mentioned this pull request Nov 28, 2024

feat: [FC-0070] rendering library content in unit page #1475

Merged

PKulkoRaccoonGang force-pushed the Peter_Kulko/edit-modal-for-advanced-xblocks branch from 648e1ae to 0bec87f Compare February 13, 2025 07:31

feat: functionality for editing xblocks via legacy modal window

c788c40

PKulkoRaccoonGang force-pushed the Peter_Kulko/edit-modal-for-advanced-xblocks branch from 0bec87f to c788c40 Compare February 13, 2025 07:32

PKulkoRaccoonGang force-pushed the Peter_Kulko/edit-modal-for-advanced-xblocks branch from 7cf8b21 to fb13bfb Compare February 13, 2025 09:59

refactor: added some tests

5699716

PKulkoRaccoonGang force-pushed the Peter_Kulko/edit-modal-for-advanced-xblocks branch from fb13bfb to 5699716 Compare February 13, 2025 10:17

PKulkoRaccoonGang mentioned this pull request Feb 13, 2025

feat: [FC-0044] Course unit - Edit iframe modal window openedx/edx-platform#35777

Merged

PKulkoRaccoonGang added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Feb 13, 2025

PKulkoRaccoonGang marked this pull request as ready for review February 13, 2025 12:00

PKulkoRaccoonGang requested a review from ihor-romaniuk February 13, 2025 12:00

PKulkoRaccoonGang added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Feb 13, 2025

ihor-romaniuk reviewed Feb 14, 2025

View reviewed changes

src/course-unit/xblock-container-iframe/hooks/useMessageHandlers.tsx Outdated Show resolved Hide resolved

src/course-unit/xblock-container-iframe/utils.ts Outdated Show resolved Hide resolved

src/generic/modal-iframe/index.tsx Outdated Show resolved Hide resolved

PKulkoRaccoonGang requested a review from ihor-romaniuk February 17, 2025 08:33

refactor: after review

9901401

PKulkoRaccoonGang force-pushed the Peter_Kulko/edit-modal-for-advanced-xblocks branch from 78a2326 to 9901401 Compare February 17, 2025 08:55

PKulkoRaccoonGang requested review from bradenmacdonald and arbrandes February 17, 2025 12:14

ihor-romaniuk approved these changes Feb 17, 2025

View reviewed changes

PKulkoRaccoonGang added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Feb 18, 2025

arbrandes approved these changes Feb 20, 2025

View reviewed changes

arbrandes merged commit 7e4ecff into openedx:master Feb 20, 2025
7 checks passed

PKulkoRaccoonGang mentioned this pull request Feb 21, 2025

feat: [FC-0044] Course unit - Edit/move modals for xblocks #985

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [FC-0070] handled edit modals from advanced xblocks #1445

feat: [FC-0070] handled edit modals from advanced xblocks #1445

PKulkoRaccoonGang commented Oct 29, 2024 •

edited

Loading

openedx-webhooks commented Oct 29, 2024 •

edited

Loading

bradenmacdonald Nov 8, 2024

codecov bot commented Feb 13, 2025 •

edited

Loading

open-craft-grove commented Feb 13, 2025

open-craft-grove commented Feb 13, 2025

open-craft-grove commented Feb 17, 2025

open-craft-grove commented Feb 17, 2025

PKulkoRaccoonGang commented Feb 17, 2025

open-craft-grove commented Feb 17, 2025

open-craft-grove commented Feb 17, 2025

arbrandes commented Feb 18, 2025

PKulkoRaccoonGang commented Feb 18, 2025 •

edited

Loading

open-craft-grove commented Feb 18, 2025

arbrandes commented Feb 18, 2025

PKulkoRaccoonGang commented Feb 19, 2025

arbrandes left a comment

feat: [FC-0070] handled edit modals from advanced xblocks #1445

feat: [FC-0070] handled edit modals from advanced xblocks #1445

Conversation

PKulkoRaccoonGang commented Oct 29, 2024 • edited Loading

Description

Supporting information

Testing instructions

Other information

openedx-webhooks commented Oct 29, 2024 • edited Loading

bradenmacdonald Nov 8, 2024

Choose a reason for hiding this comment

codecov bot commented Feb 13, 2025 • edited Loading

Codecov Report

open-craft-grove commented Feb 13, 2025

open-craft-grove commented Feb 13, 2025

open-craft-grove commented Feb 17, 2025

open-craft-grove commented Feb 17, 2025

PKulkoRaccoonGang commented Feb 17, 2025

open-craft-grove commented Feb 17, 2025

open-craft-grove commented Feb 17, 2025

arbrandes commented Feb 18, 2025

PKulkoRaccoonGang commented Feb 18, 2025 • edited Loading

open-craft-grove commented Feb 18, 2025

arbrandes commented Feb 18, 2025

PKulkoRaccoonGang commented Feb 19, 2025

arbrandes left a comment

Choose a reason for hiding this comment

PKulkoRaccoonGang commented Oct 29, 2024 •

edited

Loading

openedx-webhooks commented Oct 29, 2024 •

edited

Loading

codecov bot commented Feb 13, 2025 •

edited

Loading

PKulkoRaccoonGang commented Feb 18, 2025 •

edited

Loading