feat: update next unit button plugin for left sidebar navigation usage #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1578 +/- ##
==========================================
+ Coverage 89.92% 89.93% +0.01%
==========================================
Files 332 333 +1
Lines 5647 5654 +7
Branches 1360 1399 +39
==========================================
+ Hits 5078 5085 +7
Misses 554 554
Partials 15 15 ☔ View full report in Codecov by Sentry. |
KristinAoki
force-pushed
the
KristinAoki/update-next-button-plugin
branch
from
ecfe564 to
b4cf866
Compare
BrandonHBodine
approved these changes
Jan 28, 2025
| @@ -38,13 +38,33 @@ const UnitNavigation = ({ | |||
| const { exitActive, exitText } = GetCourseExitNavigation(courseId, intl); | |||
| const buttonText = (isLastUnit && exitText) ? exitText : intl.formatMessage(messages.nextButton); | |||
| const disabled = isLastUnit && !exitActive; | |||
| const variant = 'outline-primary'; | |||
There was a problem hiding this comment.
Nit: Pulling these out into variables is a little weird to me. I prefer the text being included in the props. Is this a normal practice in this codebase?
There was a problem hiding this comment.
I put them into a variable because they are being used in two spots and want to guarantee that their values always stay in sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
next_button_slottonext_unit_top_nav_trigger_slotto better capture its roleUnitNavigationwhen the buttons appear at the top of the unit page. This happens when using left sidebar navigation.