-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update next unit button plugin for left sidebar navigation usage #1578
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
# Next Unit Top Navigation Trigger Slot | ||
|
||
### Slot ID: `next_unit_top_nav_trigger_slot` | ||
|
||
## Description | ||
|
||
This slot is used to replace/modify/hide the next button used for unit and sequence navigation at the top of the unit page. | ||
|
||
## Example | ||
|
||
### Default content | ||
|
||
**Next unit button in at top for left sidebar navigation** | ||
 | ||
|
||
**Next unit button in horizontal navigation** | ||
 | ||
|
||
### Replaced with custom component | ||
|
||
**Next unit button in at top for left sidebar navigation** | ||
 | ||
|
||
**Next unit button in horizontal navigation** | ||
 | ||
 | ||
|
||
The following `env.config.jsx` will replace the next unit/sequence button at the top of the unit page. This can be used control the | ||
button's `onClick` atrribute or change the name of the button. | ||
|
||
```js | ||
import { DIRECT_PLUGIN, PLUGIN_OPERATIONS } from '@openedx/frontend-plugin-framework'; | ||
|
||
const config = { | ||
pluginSlots: { | ||
next_unit_top_nav_trigger_slot: { | ||
keepDefault: false, | ||
plugins: [ | ||
{ | ||
op: PLUGIN_OPERATIONS.Insert, | ||
widget: { | ||
id: 'custom_button_component', | ||
type: DIRECT_PLUGIN, | ||
RenderWidget: () => ( | ||
<button>📊</button> | ||
), | ||
}, | ||
}, | ||
] | ||
} | ||
}, | ||
} | ||
|
||
export default config; | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
import React from 'react'; | ||
|
||
import { PluginSlot } from '@openedx/frontend-plugin-framework'; | ||
|
||
import NextButton from '../../courseware/course/sequence/sequence-navigation/generic/NextButton'; | ||
|
||
interface Props { | ||
courseId: string | ''; | ||
disabled: boolean; | ||
buttonText: string | ''; | ||
nextLink: string; | ||
sequenceId: string; | ||
unitId: string; | ||
onClickHandler: () => void; | ||
variant: string; | ||
buttonStyle: string; | ||
} | ||
|
||
export const NextUnitTopNavTriggerSlot : React.FC<Props> = ({ | ||
courseId, | ||
disabled, | ||
buttonText, | ||
nextLink, | ||
sequenceId, | ||
onClickHandler, | ||
variant, | ||
buttonStyle, | ||
}) => ( | ||
<PluginSlot | ||
id="next_unit_top_nav_trigger_slot" | ||
pluginProps={{ | ||
courseId, | ||
disabled, | ||
buttonText, | ||
nextLink, | ||
sequenceId, | ||
onClickHandler, | ||
variant, | ||
buttonStyle, | ||
}} | ||
> | ||
<NextButton | ||
{...{ | ||
variant, | ||
buttonStyle, | ||
onClickHandler, | ||
nextLink, | ||
disabled, | ||
buttonText, | ||
}} | ||
/> | ||
</PluginSlot> | ||
); |
Binary file added
BIN
+22.1 KB
src/plugin-slots/NextUnitTopNavTriggerSlot/screenshot_horizontal_nav_custom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+19.5 KB
src/plugin-slots/NextUnitTopNavTriggerSlot/screenshot_horizontal_nav_default.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+13.7 KB
src/plugin-slots/NextUnitTopNavTriggerSlot/screenshot_unit_at_top_custom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+15.9 KB
src/plugin-slots/NextUnitTopNavTriggerSlot/screenshot_unit_at_top_default.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Pulling these out into variables is a little weird to me. I prefer the text being included in the props. Is this a normal practice in this codebase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put them into a variable because they are being used in two spots and want to guarantee that their values always stay in sync