chore: Remove python < 3.11 references and Tutor < 18 #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmtcril
commented
Jan 24, 2025
| @@ -3,6 +3,6 @@ bcrypt | |||
| importlib-resources | |||
| openedx-atlas | |||
| transifex-python | |||
| tutor>=15 | |||
| tutor>=18 | |||
There was a problem hiding this comment.
This is a no-op since the rest of the requirements are already at 19.1
bmtcril
commented
Jan 24, 2025
| @@ -1,5 +1,5 @@ | |||
| RUN --mount=type=cache,target=/openedx/.cache/pip,sharing=shared \ | |||
| pip install "platform-plugin-aspects==v0.11.7" | |||
| pip install "git+https://github.com/openedx/platform-plugin-aspects.git@bmtcril/drop_py_38" | |||
There was a problem hiding this comment.
Can't merge until this is released
bmtcril
commented
Jan 24, 2025
| @@ -13,7 +13,6 @@ | |||
| from tutor import hooks | |||
|
|
|||
| from .__about__ import __version__ | |||
| from .commands_v0 import COMMANDS as TUTOR_V0_COMMANDS | |||
There was a problem hiding this comment.
v0 commands were from earlier (pre-Palm?) versions or Tutor which we no longer support
6 tasks
These are requirements files that go in the Aspects and Aspects-Superset images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #935
Closes #1013
These are our first round of breaking changes for Aspects 2.0 - the rest of the Python 3.8 removal and dropping support for Open edX Nutmeg, Olive, and Palm (which all required Python 3.8).