Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go-sdk): allow empty string for ulid #145

Merged
merged 2 commits into from
Jun 28, 2023
Merged

fix(go-sdk): allow empty string for ulid #145

merged 2 commits into from
Jun 28, 2023

Conversation

adriantam
Copy link
Member

@adriantam adriantam commented Jun 27, 2023 •
edited
Loading

Description

For Go-SDK, allow empty string for ulid

References

Close openfga/go-sdk#36
Corresponding Go-SDK change: openfga/go-sdk#37

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@adriantam adriantam requested a review from a team as a code owner June 27, 2023 23:21
@adriantam adriantam merged commit 102d7b6 into main Jun 28, 2023
5 checks passed
@adriantam adriantam deleted the fix/gosdk_allow_empty_authid branch June 28, 2023 17:31
@adriantam adriantam mentioned this pull request Jul 6, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to allow empty string for ulid
2 participants
@adriantam @rhamzeh