Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8341059: Change Entrust TLS distrust date to November 12, 2024 #1015

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Sep 27, 2024

Hi all,

This pull request contains a backport of commit f554c3ff from the openjdk/jdk repository.

The commit being backported was authored by Rajan Halade on 27 Sep 2024 and was reviewed by Sean Mullan.

The commit does not apply cleanly to 21u-dev due to the absence of JDK-8339560. Equivalent changes to those in distrust/Entrust.java are applied to Entrust/Distrust.java instead.

The tests in test/jdk/sun/security/ssl/X509TrustManagerImpl/Entrust pass with the updated build and fail against 21.0.4.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Error

 ⚠️ This PR only contains changes already present in the target

Issues

  • JDK-8341059: Change Entrust TLS distrust date to November 12, 2024 (Enhancement - P2)
  • JDK-8341087: Change Entrust TLS distrust date to November 12, 2024 (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1015/head:pull/1015
$ git checkout pull/1015

Update a local copy of the PR:
$ git checkout pull/1015
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1015/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1015

View PR using the GUI difftool:
$ git pr show -t 1015

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1015.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2024

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 27, 2024

@gnu-andrew This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot changed the title Backport f554c3ffce7599fdb535b03db4a6ea96870b3c2d 8341059: Change Entrust TLS distrust date to November 12, 2024 Sep 27, 2024
@openjdk
Copy link

openjdk bot commented Sep 27, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 27, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2024

Webrevs

Copy link
Contributor

@martinuy martinuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Sep 28, 2024

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@gnu-andrew
Copy link
Member Author

/approval request Distrust date needs to be moved later across all updates that picked up JDK-8337664. Patch did not backport cleanly and has been reviewed by Martin Balao.

@gnu-andrew
Copy link
Member Author

Looks good to me.

Thanks Martin for the quick review.

@openjdk
Copy link

openjdk bot commented Sep 28, 2024

@gnu-andrew
8341059: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Sep 28, 2024
@jerboaa
Copy link
Contributor

jerboaa commented Sep 30, 2024

@gnu-andrew Please integrate when you get a chance. Thanks!

@jerboaa
Copy link
Contributor

jerboaa commented Oct 1, 2024

Change of plans. I think we are going to integrate this with openjdk/jdk21u#456 instead so as to bring it to 21.0.5. Please close this one. Thanks!

@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants