-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8341059: Change Entrust TLS distrust date to November 12, 2024 #1015
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
@gnu-andrew This change is no longer ready for integration - check the PR body for details. |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
/approval request Distrust date needs to be moved later across all updates that picked up JDK-8337664. Patch did not backport cleanly and has been reviewed by Martin Balao. |
Thanks Martin for the quick review. |
@gnu-andrew |
@gnu-andrew Please integrate when you get a chance. Thanks! |
Change of plans. I think we are going to integrate this with openjdk/jdk21u#456 instead so as to bring it to 21.0.5. Please close this one. Thanks! |
Hi all,
This pull request contains a backport of commit f554c3ff from the openjdk/jdk repository.
The commit being backported was authored by Rajan Halade on 27 Sep 2024 and was reviewed by Sean Mullan.
The commit does not apply cleanly to 21u-dev due to the absence of JDK-8339560. Equivalent changes to those in
distrust/Entrust.java
are applied toEntrust/Distrust.java
instead.The tests in
test/jdk/sun/security/ssl/X509TrustManagerImpl/Entrust
pass with the updated build and fail against 21.0.4.Thanks!
Progress
Error
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1015/head:pull/1015
$ git checkout pull/1015
Update a local copy of the PR:
$ git checkout pull/1015
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1015/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1015
View PR using the GUI difftool:
$ git pr show -t 1015
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1015.diff
Webrev
Link to Webrev Comment