-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8341059: Change Entrust TLS distrust date to November 12, 2024 #456
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
openjdk/jdk21u-dev#1015 is in |
/integrate |
Thanks for the approval! |
"The patch is identical to the one by Andrew" Yet, you don't even bother to credit me. |
I'm sorry, I meant to by saying "Thanks, Andrew, for preparing the field, here!" Maybe "pave the way" would have been better because your change went clean all the way to 11! |
This moves the jdk21u-dev backport by Andrew (openjdk/jdk21u-dev#1015) to jdk21u.
The patch is identical to the one by Andrew. I.e., the changes to the original version in head are:
"The commit does not apply cleanly to 21u-dev due to the absence of JDK-8339560. Equivalent changes to those in distrust/Entrust.java are applied to Entrust/Distrust.java instead."
Thanks, Andrew, for preparing the field, here!
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/456/head:pull/456
$ git checkout pull/456
Update a local copy of the PR:
$ git checkout pull/456
$ git pull https://git.openjdk.org/jdk21u.git pull/456/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 456
View PR using the GUI difftool:
$ git pr show -t 456
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/456.diff
Webrev
Link to Webrev Comment