-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-3539: Add help menu app to the spa-assemble-config.json #822
Conversation
@ibacher @denniskigen is this okay to merge? The help menu contains only the following and does not have any pending work: The tutorial menu will be injected later via the openmrs-esm-user-onboarding app. |
I kind of prefer to add this in after the release, if that's ok. |
Sure thing! |
frontend/spa-assemble-config.json
Outdated
"@openmrs/esm-system-admin-app": "next", | ||
"@openmrs/esm-help-menu-app": "next" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List here appears to be organized alphabetically, so I guess we keep that (I had been keeping this list organized by which monorepo they appeared in to make it easier to fill out, but I guess that changed somewhere along the line).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure will do that.
@Vijaykv5 The icon looks odd because you hardcoded the position, can we get it fixed as we discussed on the ux call? It should be flexible and should look like this: When the dev tool icon is visible (I took a screenshot from one of your old PRs. The color should be white, obviously): When the dev tool icon is not there: |
Or I don't mind flipping icons, ex: The help icon always stays at the bottom and the dev tools will be on top of it. |
It may look something like this @jayasanka-sack |
Looks Good! Can we align the dev tools button with the help icon? |
Yes we can! |
What this PR is about
This PR adds the Help Menu module to the reference application
Ticket
O3-3539