Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-3539: Add help menu app to the spa-assemble-config.json #822

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

Vijaykv5
Copy link
Contributor

@Vijaykv5 Vijaykv5 commented Jul 3, 2024

What this PR is about

This PR adds the Help Menu module to the reference application

Ticket

O3-3539

@Vijaykv5 Vijaykv5 changed the title O3-3539 : Added help menu module O3-3539 : Add help menu module openmrs distro Jul 3, 2024
@jayasanka-sack jayasanka-sack changed the title O3-3539 : Add help menu module openmrs distro (feat) O3-3539: Add help menu app openmrs distro Jul 3, 2024
@jayasanka-sack jayasanka-sack changed the title (feat) O3-3539: Add help menu app openmrs distro (feat) O3-3539: Add help menu app to the spa-assemble-config.json Jul 3, 2024
@jayasanka-sack
Copy link
Member

jayasanka-sack commented Jul 3, 2024

@ibacher @denniskigen is this okay to merge?

The help menu contains only the following and does not have any pending work:
image

The tutorial menu will be injected later via the openmrs-esm-user-onboarding app.

@ibacher
Copy link
Member

ibacher commented Jul 3, 2024

I kind of prefer to add this in after the release, if that's ok.

@jayasanka-sack
Copy link
Member

Sure thing!

Comment on lines 37 to 38
"@openmrs/esm-system-admin-app": "next",
"@openmrs/esm-help-menu-app": "next"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List here appears to be organized alphabetically, so I guess we keep that (I had been keeping this list organized by which monorepo they appeared in to make it easier to fill out, but I guess that changed somewhere along the line).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure will do that.

@Vijaykv5 Vijaykv5 requested a review from ibacher July 8, 2024 14:34
@ibacher ibacher merged commit 38b3a41 into openmrs:main Jul 10, 2024
13 checks passed
@jayasanka-sack
Copy link
Member

@Vijaykv5 The icon looks odd because you hardcoded the position, can we get it fixed as we discussed on the ux call? It should be flexible and should look like this:

When the dev tool icon is visible (I took a screenshot from one of your old PRs. The color should be white, obviously):
Screenshot 2024-07-10 at 13 17 28

When the dev tool icon is not there:

Screenshot 2024-07-10 at 13 20 14

@jayasanka-sack
Copy link
Member

Or I don't mind flipping icons, ex: The help icon always stays at the bottom and the dev tools will be on top of it.

@Vijaykv5
Copy link
Contributor Author

Or I don't mind flipping icons, ex: The help icon always stays at the bottom and the dev tools will be on top of it.

Screenshot 2024-07-10 at 7 02 35 PM

It may look something like this @jayasanka-sack

@jayasanka-sack
Copy link
Member

Looks Good! Can we align the dev tools button with the help icon?

@Vijaykv5
Copy link
Contributor Author

Looks Good! Can we align the dev tools button with the help icon?

Yes we can!
will be Adding a PR on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants