You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, I didn't realize you aren't linting or typescript-building this, or I wouldn't have reviewed it in the first place. Please get your dev environment together. This is full of lint and type errors.
jona42-ui
changed the title
(feat)O3-2211: persist annotated images to attachment module
(feat)O3-2211: persist annotated images to attachment module using a custom simple svg editor
Sep 25, 2023
jona42-ui
changed the title
(feat)O3-2211: persist annotated images to attachment module using a custom simple svg editor
(feat)O3-2211: annotate and persist annotated images to attachment module using a custom simple svg editor
Sep 26, 2023
Just glancing at the video, this looks more like what I was expecting for this project. While a proper design from UX designers would be nice, this is, design-wise, a big lift and we don't have any funding that would cover this work.
Some initial thoughts:
The upload widget should be a standard Carbon button
I would locate the various toolbar-type widgets either in the global header or in a left panel
The color selection widget should also be more inline with the others (it's probably better here to use an icon rather than text; there are very likely appropriate icons for this)
The user should be able to give the image a sensible name when saving as an attachment
Just glancing at the video, this looks more like what I was expecting for this project. While a proper design from UX designers would be nice, this is, design-wise, a big lift and we don't have any funding that would cover this work.
Some initial thoughts:
* The upload widget should be a standard Carbon button
* I would locate the various toolbar-type widgets either in the global header or in a left panel
* The color selection widget should also be more inline with the others (it's probably better here to use an icon rather than text; there are very likely appropriate icons for this)
* The user should be able to give the image a sensible name when saving as an attachment
jona42-ui
changed the title
(feat)O3-2211: annotate and persist annotated images to attachment module using a custom simple svg editor
(feat)O3-2211: draw using a custom simple svg editor
Oct 30, 2023
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jona42-ui
changed the title
Issue
O3-2211
Objective
This PR provides a means to allow rendering image to the drawing widget and attachment to a specific patient on save