Remove validation that made keys starting or ending with . - or _ invalid, catch all exceptions in the parse json processor #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
…alid, catch all exceptions in the parse json processor Signed-off-by: Taylor Gray <tylgry@amazon.com>
kkondaka
previously approved these changes
Jun 26, 2023
engechas
reviewed
Jun 27, 2023
| writeToRoot(event, parsedJson); | ||
| } else { | ||
| event.put(destination, parsedJson); | ||
| final Event event = record.getData(); |
There was a problem hiding this comment.
Nit: seems like this block is double indented which is showing more of a diff than there actually is
| } | ||
|
|
||
| if ((i == 0 || i == key.length() - 1 || previous == '/' || next == '/') && (c == '_' || c == '.' || c == '-')) { | ||
| return false; |
There was a problem hiding this comment.
What was the motivation for not allowing these characters initially? I'm wondering what the consequences of this change would be
There was a problem hiding this comment.
I am not sure what the reasoning was
There was a problem hiding this comment.
This is the PR where I added this custom code (https://github.com/opensearch-project/data-prepper/pull/725/files). But the regex pattern that was used to validate before (which disallowed starting or ending with these characters) was added by @cmanning09
kkondaka
approved these changes
Jun 27, 2023
4 tasks
|
Moved to #2945 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.,-, or_in JacksonEventparse_jsonprocessorIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.