Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validation that made keys starting or ending with . - or _ invalid, catch all exceptions in the parse json processor #2945

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

graytaylor0
Copy link
Member

@graytaylor0 graytaylor0 commented Jun 27, 2023

Description

Messed up my git history so following up on #2936

Issues Resolved

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…alid, catch all exceptions in the parse json processor

Signed-off-by: Taylor Gray <tylgry@amazon.com>
Signed-off-by: Taylor Gray <tylgry@amazon.com>
@graytaylor0 graytaylor0 merged commit 05d229a into opensearch-project:main Jun 27, 2023
24 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.3 2.3
# Navigate to the new working tree
cd .worktrees/backport-2.3
# Create a new branch
git switch --create backport/backport-2945-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 05d229a06ceddb21cd9dedcaf49b1d455272fe6f
# Push it to GitHub
git push --set-upstream origin backport/backport-2945-to-2.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.3

Then, create a pull request where the base branch is 2.3 and the compare/head branch is backport/backport-2945-to-2.3.

asifsmohammed pushed a commit to asifsmohammed/data-prepper that referenced this pull request Jul 11, 2023
…alid, catch all exceptions in the parse json processor (opensearch-project#2945)

Remove validation that made keys starting or ending with . - or _ invalid, catch all exceptions in the parse json processor

Signed-off-by: Taylor Gray <tylgry@amazon.com>
(cherry picked from commit 05d229a)
asifsmohammed added a commit that referenced this pull request Jul 12, 2023
#3007)

* Remove validation that made keys starting or ending with . - or _ invalid, catch all exceptions in the parse json processor (#2945)

Remove validation that made keys starting or ending with . - or _ invalid, catch all exceptions in the parse json processor

Signed-off-by: Taylor Gray <tylgry@amazon.com>
(cherry picked from commit 05d229a)

* Removed readme

Signed-off-by: Asif Sohail Mohammed <nsifmoh@amazon.com>

---------

Signed-off-by: Asif Sohail Mohammed <nsifmoh@amazon.com>
Co-authored-by: Taylor Gray <tylgry@amazon.com>
MaGonzalMayedo pushed a commit to MaGonzalMayedo/data-prepper that referenced this pull request Jul 25, 2023
…alid, catch all exceptions in the parse json processor (opensearch-project#2945)

Remove validation that made keys starting or ending with . - or _ invalid, catch all exceptions in the parse json processor

Signed-off-by: Taylor Gray <tylgry@amazon.com>
Signed-off-by: Marcos Gonzalez Mayedo <alemayed@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants