-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove validation that made keys starting or ending with . - or _ invalid, catch all exceptions in the parse json processor #2945
Merged
graytaylor0
merged 2 commits into
opensearch-project:main
from
graytaylor0:KeyValidation
Jun 27, 2023
Merged
Remove validation that made keys starting or ending with . - or _ invalid, catch all exceptions in the parse json processor #2945
graytaylor0
merged 2 commits into
opensearch-project:main
from
graytaylor0:KeyValidation
Jun 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alid, catch all exceptions in the parse json processor Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
June 27, 2023 18:27
4 tasks
Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
force-pushed
the
KeyValidation
branch
from
June 27, 2023 19:08
99ba386
to
510e8cf
Compare
engechas
approved these changes
Jun 27, 2023
kkondaka
approved these changes
Jun 27, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.3 2.3
# Navigate to the new working tree
cd .worktrees/backport-2.3
# Create a new branch
git switch --create backport/backport-2945-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 05d229a06ceddb21cd9dedcaf49b1d455272fe6f
# Push it to GitHub
git push --set-upstream origin backport/backport-2945-to-2.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.3 Then, create a pull request where the |
asifsmohammed
pushed a commit
to asifsmohammed/data-prepper
that referenced
this pull request
Jul 11, 2023
…alid, catch all exceptions in the parse json processor (opensearch-project#2945) Remove validation that made keys starting or ending with . - or _ invalid, catch all exceptions in the parse json processor Signed-off-by: Taylor Gray <tylgry@amazon.com> (cherry picked from commit 05d229a)
4 tasks
asifsmohammed
added a commit
that referenced
this pull request
Jul 12, 2023
#3007) * Remove validation that made keys starting or ending with . - or _ invalid, catch all exceptions in the parse json processor (#2945) Remove validation that made keys starting or ending with . - or _ invalid, catch all exceptions in the parse json processor Signed-off-by: Taylor Gray <tylgry@amazon.com> (cherry picked from commit 05d229a) * Removed readme Signed-off-by: Asif Sohail Mohammed <nsifmoh@amazon.com> --------- Signed-off-by: Asif Sohail Mohammed <nsifmoh@amazon.com> Co-authored-by: Taylor Gray <tylgry@amazon.com>
MaGonzalMayedo
pushed a commit
to MaGonzalMayedo/data-prepper
that referenced
this pull request
Jul 25, 2023
…alid, catch all exceptions in the parse json processor (opensearch-project#2945) Remove validation that made keys starting or ending with . - or _ invalid, catch all exceptions in the parse json processor Signed-off-by: Taylor Gray <tylgry@amazon.com> Signed-off-by: Marcos Gonzalez Mayedo <alemayed@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Messed up my git history so following up on #2936
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.