-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes user_inputs field from Template and Global Context Index mapping #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
joshpalis
requested review from
dbwiddis,
owaiskazi19,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
October 23, 2023 18:44
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
============================================
- Coverage 81.46% 80.47% -0.99%
+ Complexity 285 252 -33
============================================
Files 30 30
Lines 1122 973 -149
Branches 126 98 -28
============================================
- Hits 914 783 -131
+ Misses 162 155 -7
+ Partials 46 35 -11
|
Signed-off-by: Joshua Palis <jpalis@amazon.com>
owaiskazi19
approved these changes
Oct 24, 2023
dbwiddis
approved these changes
Oct 25, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
…ing (#111) * Adding global context index mapping changes Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removes user inputs field from Template class and global context Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding toJson test for TemplateTests::testStrings() Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com> (cherry picked from commit f621b91) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
that referenced
this pull request
Oct 25, 2023
…text Index mapping (#112) Removes user_inputs field from Template and Global Context Index mapping (#111) * Adding global context index mapping changes * Removes user inputs field from Template class and global context * Adding toJson test for TemplateTests::testStrings() --------- (cherry picked from commit f621b91) Signed-off-by: Joshua Palis <jpalis@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR achieves the following :
user_inputs
fieldworkflows
,user_outputs
andresources_created
fields to typeobject
instead oftext
to support indexing dynamic json objectsTemplate
objects to the GC index and replacing each instance withTemplate::parse
/Template::toXContent
I prefer to merge this in prior to #106
Issues Resolved
Part of #88
#105
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.