Default size to 100 #122
Open
Default size to 100 #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hailong-am
reviewed
Nov 4, 2025
Signed-off-by: yyfamazon <yyf@amazon.com>
Collaborator
rithin-pullela-aws
left a comment
rithin-pullela-aws
left a comment
There was a problem hiding this comment.
Add a high level question, can you also add change log and sign your commit to fix DCO?
| # Set default size to 100 if not present in query body | ||
| query = args.query.copy() if isinstance(args.query, dict) else args.query | ||
| if isinstance(query, dict) and 'size' in query: | ||
| query['size'] = min(100, query['size']) |
Collaborator
There was a problem hiding this comment.
This would mean we would not be able to send a size > 100.
I believe this kind of restriction is not ideal, can we make it configurable in settings?
Collaborator
There was a problem hiding this comment.
Looks like a similar PR has already been raised in #114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
default size to 100
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.