Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[must-gather]Add GMR file trigger support #635

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Dec 20, 2023

The API services can only use the file trigger for GMR as apache
disables signal handling. This PR adds the file trigger config for
every server.
GMR can be triggered by

  oc exec  <service pod> -- touch /var/lib/nova

Optionally non apache based services produce GMR also via

  oc exec <service pod> -- kill -USR2 1

Related-to: https://issues.redhat.com/browse/OSPRH-730

templates/nova.conf Outdated Show resolved Hide resolved
templates/novaapi/config/nova-api-config.json Outdated Show resolved Hide resolved
The API services can only use the file trigger for GMR as apache
disables signal handling. This PR adds the file trigger config for
every server.
GMR can be triggered by

  oc exec  <service pod> -- touch /var/lib/nova

Optionally non apache based services produce GMR also via

  oc exec <service pod> -- kill -USR2 1
Copy link
Contributor

@SeanMooney SeanMooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was not aware we coudl jsut use a dir but ok that also works

perhaps not as intuitive as
/var/lib/nova/gmr_trigger but it does not require changes to edpm-ansible or the operator to create an empty file.

so over all i like this approach more thanks gibi

@openshift-ci openshift-ci bot added the lgtm label Dec 20, 2023
Copy link
Contributor

openshift-ci bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, SeanMooney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f16556a into openstack-k8s-operators:main Dec 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants