Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding filtering to susie finemapper #796

Merged
merged 17 commits into from
Oct 2, 2024
Merged

Conversation

addramir
Copy link
Contributor

@addramir addramir commented Sep 28, 2024

✨ Context

Adds filtering by lead p-value, purity, deduplication and LD clumping into fine-mapper.
Also adds columns locusStart and locusEnd to credible sets.
All works and tested.

🛠 What does this PR implement

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@addramir addramir changed the title feat: adding filtering to susie fine_mapper feat: adding filtering to susie finemapper Sep 28, 2024
@addramir addramir marked this pull request as ready for review October 1, 2024 15:34
@addramir addramir merged commit 174f8f9 into dev Oct 2, 2024
5 checks passed
@addramir addramir deleted the yt_add_fillters_to_susie branch October 2, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants