Add the options audioSource and videoSource for the quality test #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miksansegundo
force-pushed
the
audio-video-source-deviceid-options
branch
from
11a696b to
e2b9b2d
Compare
|
What is the status of this pull request? Can someone review it ? It feels like these changes may solve this issue: #133 |
|
@jeffswartz do you know what is missing for this PR to be merged? |
enricop89
reviewed
Apr 20, 2020
| if (options && options.videoSource) { | ||
| publisherOptions.videoSource = options.videoSource | ||
| } | ||
| console.log('AQUI test', publisherOptions) |
There was a problem hiding this comment.
can you remove this console log, please?
There was a problem hiding this comment.
I fixed it, @enricop89.
enricop89
reviewed
Apr 20, 2020
| @@ -140,6 +146,7 @@ function checkCreateLocalPublisher( | |||
| if (!error) { | |||
| resolve({ publisher }); | |||
| } else { | |||
| console.error('OT.initPublisher', publisherOptions, error) | |||
There was a problem hiding this comment.
can you remove this console log, please?
jeffswartz
approved these changes
Apr 20, 2020
|
Thanks for the PR, @miksansegundo. Very sorry for the delay in getting this merged in. (I'm going to add some minor release notes and merge this into the master branch today.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NetworkTestcan receive the optionsaudioSourceandvideoSourceto be tested. Both, thetestConnectivityandtestQualityuse those options to create the publisher stream.Usage: