Un-deprecate GTFS API's planConnection, deprecate plan
#6110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
changed the title
planConnection, deprecate plan
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6110 +/- ##
=============================================
- Coverage 69.85% 69.84% -0.02%
+ Complexity 17468 17457 -11
=============================================
Files 1975 1973 -2
Lines 74614 74566 -48
Branches 7640 7637 -3
=============================================
- Hits 52118 52077 -41
+ Misses 19848 19841 -7
Partials 2648 2648 ☔ View full report in Codecov by Sentry. |
|
We agreed that this can happen now. |
vesameskanen
previously approved these changes
Oct 4, 2024
optionsome
reviewed
Oct 4, 2024
Comment on lines
+6
to
+11
| /* | ||
| * Hide the deprecated queries from the left hand navigation panel. | ||
| */ | ||
| nav ul li .deprecated { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
How are they displayed without this? I'm just wondering since sometimes we use the deprecated on experimental queries (like we did for planConnection in the past), and I'm not sure if we want to hide their existence completely.
There was a problem hiding this comment.
It removes them from the left hand navigation but you can still access them from the search and if you type in the URL.
leonardehrenfried
force-pushed
the
plan-connection
branch
from
5bb6f83 to
550e8ba
Compare
vesameskanen
approved these changes
Oct 5, 2024
optionsome
approved these changes
Oct 8, 2024
t2gran
pushed a commit
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deprecates the
planquery and un-deprecatesplanConnectionwhich has been used by HSL in production for several month.Issue
#4803
Unit tests
I moved most of the integration tests from
plantoplanConnection. A single test forplanremains.Documentation
The tutorial was updated with the new query.
Also, I added a CSS override so that the deprecated queries no longer show up in our HTML documentation of the schema.