-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[core] Remove and change deprecated data() member in tensor #32569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[core] Remove and change deprecated data() member in tensor #32569
Conversation
Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
|
GenAI needs to be fixed first. Will you do that (or maybe already started)? |
Will fix that, it looks also in NVIDIA plugin must be fixed also. |
dmatveev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smirnov-alexey please have a look on NPUW-related changes (I had mine, don't see a problem here)
Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
## Description - Update usage of ov::Tensor::data() member for OV 26.0 to fix build issues. - No test update, functionality not changed. - No docs update required. Blocked PR: - openvinotoolkit/openvino#32569 <!--- Jira ticket number (e.g., 123). Delete if there's no ticket. Don't include full link or project name. --> Ticket: CVS-174872 ## Checklist: - [x] Tests have been updated or added to cover the new code <!--- If the change isn't maintenance related, update the tests at https://github.com/openvinotoolkit/openvino.genai/tree/master/tests or explain in the description why the tests don't need an update. --> - [x] This patch fully addresses the ticket. <!--- If follow-up pull requests are needed, specify in description. --> - [x] I have made corresponding changes to the documentation Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
## Description - Remove dead code which cause compilation error with updated ov::Tensor::data() member. for OV 26.0 to fix build issues. - No test update, functionality not changed. - No docs update required. Blocked PR: - openvinotoolkit/openvino#32569 <!--- Jira ticket number (e.g., 123). Delete if there's no ticket. Don't include full link or project name. --> Ticket: CVS-174872 ## Checklist: - [x] Tests have been updated or added to cover the new code <!--- If the change isn't maintenance related, update the tests at https://github.com/openvinotoolkit/openvino.genai/tree/master/tests or explain in the description why the tests don't need an update. --> - [x] This patch fully addresses the ticket. <!--- If follow-up pull requests are needed, specify in description. --> - [x] I have made corresponding changes to the documentation --------- Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
Details:
ov::Tensor::data()returns const pointer for const TensorBlocked by:
Tickets: