Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed navigation oddities with single page docs #25

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

josephlewis42
Copy link
Collaborator

Fixes #16. Changes the logic for expanding sections to ignore the special case of the index. Example showing Lua now works:

image

I additionally validated RequireJS which has much of its content in the index but other parts in different pages, it behaves as expected.

A longer term, better fix for this is #24.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.61%. Comparing base (2e61d1f) to head (ffb63ca).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   92.56%   92.61%   +0.04%     
==========================================
  Files           4        4              
  Lines         323      325       +2     
  Branches       43       44       +1     
==========================================
+ Hits          299      301       +2     
  Misses         22       22              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephlewis42 josephlewis42 marked this pull request as ready for review September 16, 2024 19:02
Copy link
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit 653029f into main Sep 17, 2024
8 checks passed
@benoit74 benoit74 deleted the index-nav branch September 17, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapse navigation tree
2 participants