Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FTS support. #27

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Added FTS support. #27

merged 1 commit into from
Sep 24, 2024

Conversation

josephlewis42
Copy link
Collaborator

@josephlewis42 josephlewis42 commented Sep 23, 2024

Fixes #13

Demo of this working by searching "apiVersion" in the Kubernetes docs:

image

The existing e2e tests cover this code path, although they don't explicitly check the resulting Zim for conformance.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.72%. Comparing base (abf16af) to head (2df177e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   92.70%   92.72%   +0.02%     
==========================================
  Files           4        4              
  Lines         329      330       +1     
  Branches       44       44              
==========================================
+ Hits          305      306       +1     
  Misses         22       22              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done!

@benoit74 benoit74 merged commit be6bccb into main Sep 24, 2024
8 checks passed
@benoit74 benoit74 deleted the jl/feat/fts branch September 24, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full-text search is not working
2 participants