Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exception if there are no videos in the playlists #365

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

dan-niles
Copy link
Collaborator

Fix #347

Raise exception if there are no videos in the playlists instead of creating an empty ZIM file.
Tested with this playlist: https://www.youtube.com/playlist?list=PL5glJe_RySVnGr4P1ZCW3Ou32pkz0z-yY

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 1.50%. Comparing base (f9d4b1e) to head (7cbb02f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/youtube2zim/scraper.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #365      +/-   ##
========================================
- Coverage   1.50%   1.50%   -0.01%     
========================================
  Files         11      11              
  Lines       1128    1130       +2     
  Branches     170     171       +1     
========================================
  Hits          17      17              
- Misses      1111    1113       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan-niles dan-niles marked this pull request as ready for review October 14, 2024 10:16
@dan-niles dan-niles self-assigned this Oct 14, 2024
@dan-niles dan-niles requested a review from benoit74 October 14, 2024 10:16
@dan-niles dan-niles force-pushed the handle-empty-playlists branch from e5c34b9 to 7cbb02f Compare October 14, 2024 10:22
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit 46c1d3c into main Oct 14, 2024
10 checks passed
@benoit74 benoit74 deleted the handle-empty-playlists branch October 14, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What happens when there is no video in channel / playlist?
2 participants