Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exception if there are no videos in the playlists #365

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Raise exception if there are no videos in the playlists #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Raise exception if there are no videos in the playlists (#347)

## [3.2.0] - 2024-10-11

### Deprecated
Expand Down
4 changes: 4 additions & 0 deletions scraper/src/youtube2zim/scraper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,10 @@

for playlist in empty_playlists:
self.playlists.remove(playlist)

# Raise exception if no videos found in playlists
if not self.playlists:
raise Exception("No videos found in playlists")

Check warning on line 624 in scraper/src/youtube2zim/scraper.py

View check run for this annotation

Codecov / codecov/patch

scraper/src/youtube2zim/scraper.py#L624 

Added line #L624 was not covered by tests
self.videos_ids = [*all_videos.keys()] # unpacking so it's subscriptable

def download_video_files(self, max_concurrency):
Expand Down