Talkback does not read the expected text

[JishnuGoyal]

Describe the bug

On the enter pin page on a user profile, the talkback directly reads the enter pin text. Expectation: It should start from Hi, (user name), Please enter your pin.

To Reproduce
Steps to reproduce the behavior:

1. Go to a user profile which has a pin with talkback turned on
2. Talkback directly is focussed on text input field and reads "Pin verification".

Environment

• Device/emulator being used:
• Android or SDK version (e.g. Android 5 or SDK 21): Android 12
• App version (you can get this through system app settings or via the admin controls menu in-app): 0.10-beta-5e64fae55e

[BenHenning]

This seems like an a11y nice-to-have, not a broken flow, so we don't need to block the release.

[Vishwajith-Shettigar]

can i work on this issue ?

[adhiamboperes]

Hi @Vishwajith-Shettigar, could you work on getting your first PR approved, then you can start on this other issue? Thanks!

[Vishwajith-Shettigar]

Hi @Vishwajith-Shettigar, could you work on getting your first PR approved, then you can start on this other issue? Thanks!

yeah okay

[adhiamboperes]

@Vishwajith-Shettigar, could you please begin work on this issue?

[Vishwajith-Shettigar]

@Vishwajith-Shettigar, could you please begin work on this issue?

Sure thank you

[Vishwajith-Shettigar]

@adhiamboperes Can you please confirm me issue is addressing the same page in screenshot

[MohitGupta121]

@Vishwajith-Shettigar correct this is same.

[adhiamboperes]

@Vishwajith-Shettigar correct this is same.

Thanks @MohitGupta121. @Vishwajith-Shettigar, please let us know if you have any questions about the solution

[Vishwajith-Shettigar]

@adhiamboperes We are expecting when activity opens talk back should read Hi, (user name), Please enter your pin. then after talk back will focus on Edit text. Am I going right ?

[Vishwajith-Shettigar]

@Vishwajith-Shettigar correct this is same.

thank you

[adhiamboperes]

@adhiamboperes We are expecting when activity opens talk back should read Hi, (user name), Please enter your pin. then after talk back will focus on Edit text. Am I going right ?

The user greeting textview needs a content description to be read, same to the enter pin textview

[Vishwajith-Shettigar]

@adhiamboperes We are expecting when activity opens talk back should read Hi, (user name), Please enter your pin. then after talk back will focus on Edit text. Am I going right ?

The user greeting textview needs a content description to be read, same to the enter pin textview

Talk back reads activity label first that is "pin verification" now what should i do to mute that, am i allowed to remove activity label ?

[adhiamboperes]

The user greeting textview needs a content description to be read, same to the enter pin textview

Talk back reads activity label first that is "pin verification" now what should i do to mute that, am i allowed to remove activity label ?

What we need is for talkback to read the texts on the screen in the order in which they appear. The way to do this is to make sure the textviews all have corresponding content descriptions. The activity labels shoud not be modified. To clear any confusion caused by the issue description, please just make sure what we have on the screen is what is actually being read.

[Vishwajith-Shettigar]

The user greeting textview needs a content description to be read, same to the enter pin textview

Talk back reads activity label first that is "pin verification" now what should i do to mute that, am i allowed to remove activity label ?

What we need is for talkback to read the texts on the screen in the order in which they appear. The way to do this is to make sure the textviews all have corresponding content descriptions. The activity labels shoud not be modified. To clear any confusion caused by the issue description, please just make sure what we have on the screen is what is actually being read.

all i just need is to give content description right ? or something else ?

[adhiamboperes]

Please start there and confirm that the solution works as expected. Afterwards you can also check the corresponding test files and add tests for the new content descriptions. You can find the pattern for testing from existing tests on the same.

[Vishwajith-Shettigar]

@adhiamboperes i set content description for user greeting textview and enter pin textview, but the issue is talback directly focus on edit text when we enter the activity.

[adhiamboperes]

@adhiamboperes i set content description for user greeting textview and enter pin textview, but the issue is talback directly focus on edit text when we enter the activity.

There is an xml attribute android:importantForAccessibility="yes" that tells talkback a view is important. Please research it a bit and then try it.

[Vishwajith-Shettigar]

@adhiamboperes i set content description for user greeting textview and enter pin textview, but the issue is talback directly focus on edit text when we enter the activity.

There is an xml attribute android:importantForAccessibility="yes" that tells talkback a view is important. Please research it a bit and then try it.

I have tried that, if i make android:importantForAccessibility="no" for edit text that works but edit text wont be able to read by talkback even if user touch it

[Vishwajith-Shettigar]

@adhiamboperes i set content description for user greeting textview and enter pin textview, but the issue is talback directly focus on edit text when we enter the activity.

There is an xml attribute android:importantForAccessibility="yes" that tells talkback a view is important. Please research it a bit and then try it.

I have tried that, if i make android:importantForAccessibility="no" for edit text that works but edit text wont be able to read by talkback even if user touch it

and i have tried android:importantForAccessibility="yes" for textviews but there is no difference

[adhiamboperes]

Can you please research this and let me know what you come up with?

[Vishwajith-Shettigar]

Okay i will try

[Vishwajith-Shettigar]

I came up with a solution, talkback is directly focusing on edit text because of edit text auto focus by ,making edittext focusable="false" and dynamically setting focusable="true" when user click on edit text, this might solve.

[adhiamboperes]

That sounds like a great idea. Please go ahead with the implementation.

[Vishwajith-Shettigar]

That sounds like a great idea. Please go ahead with the implementation.

@adhiamboperes here is PR #5152

[adhiamboperes]

I have reviewed the talkback experience on this screen---it sounds to me like the text being read is sufficient for the user to know what is required, and I don't think there is need to modify it at this point. Here is a recording. @seanlip , @BenHenning, please review.

Screenrecorder-2023-10-06-17-31-32-803.mp4

[seanlip]

@adhiamboperes I'm not sure what the expected behaviour for a11y is when there is autofocus enabled -- @BenHenning might know better here so it might be worth asking him directly.

One thought I had -- will they know that there's a "Forgot PIN?" option on the screen, if we don't enable the whole screen to be read at the outset? I feel like, based on this, I lean towards thinking it should be changed along the lines that @JishnuGoyal proposed, if only for consistency with other screens (and thinking about the case where we might add more stuff to this screen in future).

Just my 2c.

[seanlip]

Also to clarify -- my previous comment was meant to describe what I think is the "ideal" case, but I think that fixing this is still probably fairly low impact and that it might be better to work on higher-impact issues instead.

(@adhiamboperes just a note, we probably shouldn't really be putting "good first labels" on low-impact projects in general, if there are other things that would be more important to do. Better to break down the higher-impact issues if possible so that they're approachable.)

[adhiamboperes]

Thanks @seanlip, I'll keep that in mind.