Fix #4739 Talkback does not read the expected text

[Vishwajith-Shettigar]

Explanation

Fix #4739, edittext requesting focus only when reader is off will resolve this issue.

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Before fix

before.mp4

After fix

Talkback On

on.mp4

Talkback Off

off.mp4

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

[Vishwajith-Shettigar]

@adhiamboperes PTAL

[adhiamboperes]

Thanks @Vishwajith-Shettigar. Please add a talkback screen recording to your PR description. You also need to add tests as mentioned in the issue discussion.

[oppiabot]

Unassigning @adhiamboperes since the review is done.

[oppiabot]

Hi @Vishwajith-Shettigar, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

[Vishwajith-Shettigar]

Thanks @Vishwajith-Shettigar. Please add a talkback screen recording to your PR description. You also need to add tests as mentioned in the issue discussion.

@adhiamboperes,PTAL I have attached screen recordings. Thank you

[oppiabot]

Unassigning @Vishwajith-Shettigar since a re-review was requested. @Vishwajith-Shettigar, please make sure you have addressed all review comments. Thanks!

[adhiamboperes]

Thanks @Vishwajith-Shettigar.

So the "after" video you added does not fully illustrate that the problem has been solved. Instead of interrupting talkback, could you please let it read out the full text? I expect all the text on the screen to be read until the edittext. If you find that the textviews are not being read then it means that they have no content description, and you shoukd add some.

[Vishwajith-Shettigar]

Thanks @Vishwajith-Shettigar.

So the "after" video you added does not fully illustrate that the problem has been solved. Instead of interrupting talkback, could you please let it read out the full text? I expect all the text on the screen to be read until the edittext. If you find that the textviews are not being read then it means that they have no content description, and you shoukd add some.

I thought textviews text should be read only when user click on them . So you are saying when we enter activity, talk back should read all the text in the textviews automatically until edit text, am i right ? please let me know if there is any issue with what i'm actually thinking.

[adhiamboperes]

Thanks @Vishwajith-Shettigar.
So the "after" video you added does not fully illustrate that the problem has been solved. Instead of interrupting talkback, could you please let it read out the full text? I expect all the text on the screen to be read until the edittext. If you find that the textviews are not being read then it means that they have no content description, and you shoukd add some.

I thought textviews text should be read only when user click on them . So you are saying when we enter activity, talk back should read all the text in the textviews automatically until edit text, am i right ? please let me know if there is any issue with what i'm actually thinking.

Technically yes, the swipe gestures that gets them in focus. In your video demo, I did not see that.

[Vishwajith-Shettigar]

Thanks @Vishwajith-Shettigar.
So the "after" video you added does not fully illustrate that the problem has been solved. Instead of interrupting talkback, could you please let it read out the full text? I expect all the text on the screen to be read until the edittext. If you find that the textviews are not being read then it means that they have no content description, and you shoukd add some.

I thought textviews text should be read only when user click on them . So you are saying when we enter activity, talk back should read all the text in the textviews automatically until edit text, am i right ? please let me know if there is any issue with what i'm actually thinking.

Technically yes, the swipe gestures that gets them in focus. In your video demo, I did not see that.

Okay i got it, basically talk back should read toolbar close button first automatically without user interaction, and when user click or use gesture on textview then only textview should be read.

[adhiamboperes]

Once you have make the suggested change, please add a test for the edittext being focussed/unfocussed when screen reader is on/off. See TopicFragmentTest in this PR for reference:

[adhiamboperes]

Thanks @Vishwajith-Shettigar, just some minor corrections. See in-line.

[Vishwajith-Shettigar]

@adhiamboperes, PTAL.
Thank you.

[oppiabot]

Unassigning @Vishwajith-Shettigar since a re-review was requested. @Vishwajith-Shettigar, please make sure you have addressed all review comments. Thanks!

[adhiamboperes]

LGTM, thanks @Vishwajith-Shettigar!

[oppiabot]

Unassigning @adhiamboperes since they have already approved the PR.

[oppiabot]

Hi @Vishwajith-Shettigar, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!