Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4739 Talkback does not read the expected text #5152

Merged
merged 41 commits into from
Oct 19, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
d426901
talkbackissuefixed
Vishwajith-Shettigar Sep 15, 2023
c78554c
talkbackissuefixed
Vishwajith-Shettigar Sep 15, 2023
25fc0b9
talkbackissuefixed
Vishwajith-Shettigar Sep 16, 2023
964536a
talkbackissuefixedd
Vishwajith-Shettigar Sep 17, 2023
51231df
talkbackissuefixedd
Vishwajith-Shettigar Sep 17, 2023
d8cb87a
talkbackissuefixedd
Vishwajith-Shettigar Sep 17, 2023
9108e3b
talkbackissuefixedtest
Vishwajith-Shettigar Sep 17, 2023
43bf81e
talkbackisssuecommit8
Vishwajith-Shettigar Sep 19, 2023
3db71d1
talkbackisssuecommit9
Vishwajith-Shettigar Sep 20, 2023
83b5d03
Merge branch 'develop' into talkbackissue
Vishwajith-Shettigar Sep 20, 2023
42a6fd7
talkbackisssuecommit10
Vishwajith-Shettigar Sep 20, 2023
0d3b01b
talkbackisssuecommit10
Vishwajith-Shettigar Sep 20, 2023
34bef63
talkbackisssuecommit12
Vishwajith-Shettigar Sep 20, 2023
7495b1e
talkbackisssuecommit12
Vishwajith-Shettigar Sep 20, 2023
baa0f5a
Merge branch 'oppia:develop' into talkbackissue
Vishwajith-Shettigar Sep 24, 2023
ce69fe8
fixed talkback directly focusing edittext
Vishwajith-Shettigar Sep 28, 2023
ebcbbba
Merge branch 'oppia:develop' into talkbackissue
Vishwajith-Shettigar Sep 28, 2023
6bc8004
fixed talkback directly focusing edittext
Vishwajith-Shettigar Sep 29, 2023
8ad29a3
fixed talkback directly focusing edittext
Vishwajith-Shettigar Sep 29, 2023
8107759
fixed talkback directly focusing edittext
Vishwajith-Shettigar Sep 29, 2023
a44f146
Merge branch 'talkbackissue' of https://github.com/Vishwajith-Shettig…
Vishwajith-Shettigar Sep 29, 2023
2ac91ea
fixed talkback directly focusing edittext
Vishwajith-Shettigar Sep 29, 2023
d4db9e3
fixed talkback directly focusing edittext
Vishwajith-Shettigar Sep 29, 2023
deb0615
fixed talkback directly focusing edittext
Vishwajith-Shettigar Sep 29, 2023
294c2b5
fixed talkback directly focusing edittext
Vishwajith-Shettigar Sep 29, 2023
2f3992b
Merge branch 'develop' into talkbackissue
Vishwajith-Shettigar Oct 13, 2023
6322214
Merge branch 'oppia:develop' into talkbackissue
Vishwajith-Shettigar Oct 14, 2023
267e53b
fixing talkback issue
Vishwajith-Shettigar Oct 16, 2023
8ff3f42
fixing talkback issue
Vishwajith-Shettigar Oct 16, 2023
a03d7cf
talkback issue fix
Vishwajith-Shettigar Oct 17, 2023
211cf28
talkback issue fix
Vishwajith-Shettigar Oct 17, 2023
78e5b5a
fixed talkback issue
Vishwajith-Shettigar Oct 18, 2023
4932ee5
fixed talkback issue
Vishwajith-Shettigar Oct 18, 2023
48e4801
added tests
Vishwajith-Shettigar Oct 18, 2023
96359b0
added tests
Vishwajith-Shettigar Oct 18, 2023
02e03f2
added comment
Vishwajith-Shettigar Oct 18, 2023
e0a971a
added comment
Vishwajith-Shettigar Oct 18, 2023
01457ba
Merge branch 'develop' into talkbackissue
Vishwajith-Shettigar Oct 19, 2023
0f7961a
Merge branch 'develop' into talkbackissue
Vishwajith-Shettigar Oct 19, 2023
c0242aa
fixed talkback issue
Vishwajith-Shettigar Oct 19, 2023
f9e96f2
fixed talkback issue
Vishwajith-Shettigar Oct 19, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,14 @@ class PinPasswordActivityPresenter @Inject constructor(
(activity as PinPasswordActivity).finish()
}

binding.apply {
pinPasswordInputPinEditText.setOnClickListener {
pinPasswordInputPinEditText.isFocusable = true
pinPasswordInputPinEditText.isFocusableInTouchMode = true
pinPasswordInputPinEditText.requestFocus()
}
}
Vishwajith-Shettigar marked this conversation as resolved.
Show resolved Hide resolved

binding.showPin.setOnClickListener {
pinViewModel.showPassword.set(!pinViewModel.showPassword.get()!!)
if (!pinViewModel.showPassword.get()!!) {
Expand Down
4 changes: 3 additions & 1 deletion app/src/main/res/layout/pin_password_activity.xml
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,9 @@
android:imeOptions="actionNext"
android:inputType="numberPassword"
android:maxLength="@{viewModel.profile.pin.length()}"
android:textSize="14sp" />
android:textSize="14sp"
android:focusable="false"
android:focusableInTouchMode="true"/>
</com.google.android.material.textfield.TextInputLayout>

<TextView
Expand Down
Loading