Fix #4135, Fix part of #5070: In FractionInteraction UI, leave submit button enabled when answer is empty. #5224

masclot · 2023-11-13T15:09:54Z

Fix part of #5070: In FractionInteraction UI, leave submit button enabled when answer is empty. Show an error on submitting an empty answer. The error message already exists and is the same as in oppia/oppia#18379.

Demo video: leave_submit_button_enabled_on_empty_answer_v3.webm

The new error messages for empty inputs on submit are listed here: oppia/design-team#71(comment)

I added an accessibility-label exemption for FractionInputInteractionViewTestActivity as this activity is only used in tests.

Fix #4135: incidentaly, this change also fixes #4135, since I had to split the tests for FractionInputInteraction

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

… empty. Show an error on submitting an empty answer.

…pty.

adhiamboperes

Had some questions: Please see inline.

utility/src/main/java/org/oppia/android/util/math/FractionParser.kt

app/src/test/java/org/oppia/android/app/parser/FractionParsingUiErrorTest.kt

...c/main/java/org/oppia/android/app/player/state/itemviewmodel/FractionInteractionViewModel.kt

oppiabot · 2023-11-14T21:17:22Z

Hi @masclot, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

…_empty_answer

…normalized

masclot · 2023-11-27T21:32:57Z

This PR should be complete now.
Please @adhiamboperes PTAL

masclot · 2023-12-05T14:55:01Z

@adhiamboperes PTAL. Should I also include @BenHenning as reviewer?

adhiamboperes

Thanks @masclot, this LGTM.

@BenHenning, I am happy with this solution, but could you take a high level pass to verify the approach?

oppiabot · 2023-12-12T16:46:32Z

Hi @masclot, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

BenHenning

Thanks @masclot! This looks really good. Just had a few comments--PTAL.

...c/main/java/org/oppia/android/app/player/state/itemviewmodel/FractionInteractionViewModel.kt

...java/org/oppia/android/app/player/state/itemviewmodel/MathExpressionInteractionsViewModel.kt

app/src/main/res/values/strings.xml

utility/src/main/java/org/oppia/android/util/math/FractionParser.kt

…_empty_answer

masclot · 2023-12-17T21:15:24Z

@BenHenning PTAL

oppiabot · 2023-12-24T21:50:52Z

Hi @masclot, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

…_empty_answer

oppiabot · 2024-01-05T22:26:00Z

Hi @masclot, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

…_empty_answer

BenHenning

Thanks @masclot! Really sorry for the delayed review. This LGTM.

...java/org/oppia/android/app/player/state/itemviewmodel/MathExpressionInteractionsViewModel.kt

## Explanation  Fix #4135: The only thing left is removing the TODO comment, as the tests were created in #5224 ## Essential Checklist  - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only  If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide)) - For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>

masclot added 5 commits October 17, 2023 16:32

In FractionInteraction UI, leave submit button enabled when answer is…

52e1261

… empty. Show an error on submitting an empty answer.

Fix error message

c89659d

Address PR comments

0ec1bc7

Address PR comments

44a88c7

Address PR comments

21e1d91

masclot requested a review from a team as a code owner November 13, 2023 15:09

masclot requested a review from adhiamboperes November 13, 2023 15:09

masclot added 2 commits November 13, 2023 16:33

Add new error message when the text to be parsed for a fraction is em…

d37362b

…pty.

Add new error message when the text to be parsed for a fraction is em…

984d943

…pty.

masclot requested a review from a team as a code owner November 13, 2023 15:34

masclot added 3 commits November 13, 2023 17:02

Fix tests for FactionParser.

cb15252

Fix kdoc format.

8c2c1dd

Fix tests in FractionParsingUiErrorTest

f7d2dda

adhiamboperes requested changes Nov 14, 2023

View reviewed changes

oppiabot bot assigned masclot Nov 14, 2023

masclot added 5 commits November 15, 2023 09:43

Update kdoc as per review.

e8c4331

Merge remote-tracking branch 'upstream/develop' into enable_submit_on…

1c044a1

…_empty_answer

Create a separate test activity and test for fraction input interaction

dbd8e46

Add missing class to previous commit

2ab3fbf

Fix formatting

eb54fb5

masclot requested a review from a team as a code owner November 21, 2023 21:31

masclot requested a review from BenHenning November 21, 2023 21:31

masclot added 5 commits November 21, 2023 23:00

Fix test

13a110f

Merge remote-tracking branch 'upstream/develop' into enable_submit_on…

482bc70

…_empty_answer

Fix bug in which setting the text of a MathExpression was not always …

0b228c0

…normalized

Fix KDoc errors

674d631

Add accessibility exemption for new test activity

fe54f1d

masclot requested a review from a team as a code owner November 27, 2023 21:30

masclot assigned adhiamboperes Dec 5, 2023

oppiabot bot assigned BenHenning Dec 5, 2023

adhiamboperes changed the title ~~Fix part of #5070: In FractionInteraction UI, leave submit button enabled when answer is empty.~~ Fix #4135, Fix part of #5070: In FractionInteraction UI, leave submit button enabled when answer is empty. Dec 5, 2023

adhiamboperes approved these changes Dec 5, 2023

View reviewed changes

adhiamboperes assigned masclot and unassigned adhiamboperes Dec 5, 2023

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 12, 2023

BenHenning requested changes Dec 12, 2023

View reviewed changes

oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 12, 2023

BenHenning removed their assignment Dec 12, 2023

adhiamboperes mentioned this pull request Dec 14, 2023

[Feature Request]: Disable the submit button until an answer option is selected or an answer is typed #5070

Closed

12 tasks

masclot added 2 commits December 17, 2023 21:26

Merge remote-tracking branch 'upstream/develop' into enable_submit_on…

b294ccb

…_empty_answer

Apply PR review changes.

51015e2

masclot assigned BenHenning and unassigned masclot Dec 17, 2023

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 24, 2023

Merge remote-tracking branch 'upstream/develop' into enable_submit_on…

ea10dc7

…_empty_answer

oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 29, 2023

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 5, 2024

adhiamboperes removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 8, 2024

Merge remote-tracking branch 'upstream/develop' into enable_submit_on…

768ebfd

…_empty_answer

BenHenning approved these changes Jan 9, 2024

View reviewed changes

...java/org/oppia/android/app/player/state/itemviewmodel/MathExpressionInteractionsViewModel.kt Show resolved Hide resolved

BenHenning merged commit 6723268 into oppia:develop Jan 9, 2024
36 checks passed

masclot mentioned this pull request Jan 25, 2024

Fix #4135: Remove leftover TODO #5321

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #4135, Fix part of #5070: In FractionInteraction UI, leave submit button enabled when answer is empty. #5224

Fix #4135, Fix part of #5070: In FractionInteraction UI, leave submit button enabled when answer is empty. #5224

masclot commented Nov 13, 2023 •

edited

Loading

adhiamboperes left a comment

oppiabot bot commented Nov 14, 2023

masclot commented Nov 27, 2023

masclot commented Dec 5, 2023

adhiamboperes left a comment

oppiabot bot commented Dec 12, 2023

BenHenning left a comment

masclot commented Dec 17, 2023

oppiabot bot commented Dec 24, 2023

oppiabot bot commented Jan 5, 2024

BenHenning left a comment

Fix #4135, Fix part of #5070: In FractionInteraction UI, leave submit button enabled when answer is empty. #5224

Fix #4135, Fix part of #5070: In FractionInteraction UI, leave submit button enabled when answer is empty. #5224

Conversation

masclot commented Nov 13, 2023 • edited Loading

Essential Checklist

For UI-specific PRs only

adhiamboperes left a comment

Choose a reason for hiding this comment

oppiabot bot commented Nov 14, 2023

masclot commented Nov 27, 2023

masclot commented Dec 5, 2023

adhiamboperes left a comment

Choose a reason for hiding this comment

oppiabot bot commented Dec 12, 2023

BenHenning left a comment

Choose a reason for hiding this comment

masclot commented Dec 17, 2023

oppiabot bot commented Dec 24, 2023

oppiabot bot commented Jan 5, 2024

BenHenning left a comment

Choose a reason for hiding this comment

masclot commented Nov 13, 2023 •

edited

Loading