Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4135, Fix part of #5070: In FractionInteraction UI, leave submit button enabled when answer is empty. #5224

Merged
merged 28 commits into from
Jan 9, 2024
Merged

Fix #4135, Fix part of #5070: In FractionInteraction UI, leave submit button enabled when answer is empty. #5224

merged 28 commits into from
Jan 9, 2024

Commits on Oct 17, 2023

  1. In FractionInteraction UI, leave submit button enabled when answer is… 

    … empty. Show an error on submitting an empty answer.
    @masclot
    masclot committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    52e1261 View commit details
    Browse the repository at this point in the history

  2. Fix error message

    @masclot
    masclot committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    c89659d View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Address PR comments

    @masclot
    masclot committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    0ec1bc7 View commit details
    Browse the repository at this point in the history

  2. Address PR comments

    @masclot
    masclot committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    44a88c7 View commit details
    Browse the repository at this point in the history

  3. Address PR comments

    @masclot
    masclot committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    21e1d91 View commit details
    Browse the repository at this point in the history

  4. Add new error message when the text to be parsed for a fraction is em… 

    …pty.
    @masclot
    masclot committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    d37362b View commit details
    Browse the repository at this point in the history

  5. Add new error message when the text to be parsed for a fraction is em… 

    …pty.
    @masclot
    masclot committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    984d943 View commit details
    Browse the repository at this point in the history

  6. Fix tests for FactionParser.

    @masclot
    masclot committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    cb15252 View commit details
    Browse the repository at this point in the history

  7. Fix kdoc format.

    @masclot
    masclot committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    8c2c1dd View commit details
    Browse the repository at this point in the history

  8. Fix tests in FractionParsingUiErrorTest

    @masclot
    masclot committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    f7d2dda View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Update kdoc as per review.

    @masclot
    masclot committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e8c4331 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Merge remote-tracking branch 'upstream/develop' into enable_submit_on… 

    …_empty_answer
    @masclot
    masclot committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    1c044a1 View commit details
    Browse the repository at this point in the history

  2. Create a separate test activity and test for fraction input interaction

    @masclot
    masclot committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    dbd8e46 View commit details
    Browse the repository at this point in the history

  3. Add missing class to previous commit

    @masclot
    masclot committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    2ab3fbf View commit details
    Browse the repository at this point in the history

  4. Fix formatting

    @masclot
    masclot committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    eb54fb5 View commit details
    Browse the repository at this point in the history

  5. Fix test

    @masclot
    masclot committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    13a110f View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Merge remote-tracking branch 'upstream/develop' into enable_submit_on… 

    …_empty_answer
    @masclot
    masclot committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    482bc70 View commit details
    Browse the repository at this point in the history

  2. Fix bug in which setting the text of a MathExpression was not always … 

    …normalized
    @masclot
    masclot committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    0b228c0 View commit details
    Browse the repository at this point in the history

  3. Fix KDoc errors

    @masclot
    masclot committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    674d631 View commit details
    Browse the repository at this point in the history

  4. Add accessibility exemption for new test activity

    @masclot
    masclot committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    fe54f1d View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Merge branch 'develop' into enable_submit_on_empty_answer

    @adhiamboperes
    adhiamboperes authored Dec 5, 2023
    Configuration menu
    Copy the full SHA
    8b3a92e View commit details
    Browse the repository at this point in the history

  2. Improve test naming as requested in review

    @masclot
    masclot committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    a8da03c View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/develop' into enable_submit_on… 

    …_empty_answer
    @masclot
    masclot committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b7e4bbf View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/enable_submit_on_empty_answer' i… 

    …nto enable_submit_on_empty_answer
    @masclot
    masclot committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    3f225ab View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2023

  1. Merge remote-tracking branch 'upstream/develop' into enable_submit_on… 

    …_empty_answer
    @masclot
    masclot committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    b294ccb View commit details
    Browse the repository at this point in the history

  2. Apply PR review changes.

    @masclot
    masclot committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    51015e2 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. Merge remote-tracking branch 'upstream/develop' into enable_submit_on… 

    …_empty_answer
    @masclot
    masclot committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    ea10dc7 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Merge remote-tracking branch 'upstream/develop' into enable_submit_on… 

    …_empty_answer
    @masclot
    masclot committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    768ebfd View commit details
    Browse the repository at this point in the history