Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression checks: benchmarking tests #229

Merged
merged 11 commits into from
Nov 11, 2024

Conversation

lcauser-oqc
Copy link
Contributor

@lcauser-oqc lcauser-oqc commented Oct 23, 2024

Performance regression checks when merging to main.

This first PR adds a number of performance benchmarks that will enable us to ensure that we do not introduce performance regressions to QAT.

  • Added pytest-benchmark to allow us to run performance benchmarks.
  • Introduced a variety of benchmarks in the form of QASM files that will test compilation performance (let me know if there are any more you would like to see...).
  • Updated README to explain how the benchmarks can be used.

The workflow to automatically compare performance to main follows in #235.

Note: There are some temporary benchmark tests that are only there for demonstration purposes, and will be removed before merging.

@lcauser-oqc lcauser-oqc added the enhancement New feature or request label Oct 23, 2024
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 23, 2024 07:51 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 23, 2024 12:49 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 23, 2024 14:10 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 24, 2024 11:23 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 24, 2024 14:22 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 24, 2024 14:28 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 24, 2024 14:54 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 24, 2024 14:54 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 24, 2024 15:01 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 24, 2024 15:12 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 25, 2024 09:14 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 25, 2024 11:55 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 25, 2024 13:56 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc changed the title Benchmarks Performance regression checks: benchmarking tests Oct 25, 2024
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 25, 2024 14:02 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 25, 2024 14:54 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 25, 2024 15:02 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc self-assigned this Oct 25, 2024
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 28, 2024 15:07 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 28, 2024 18:15 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github October 30, 2024 11:20 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc marked this pull request as ready for review October 30, 2024 19:41
README.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@keriksson-rosenqvist keriksson-rosenqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgsach bgsach temporarily deployed to applications - github November 5, 2024 14:23 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc temporarily deployed to applications - github November 6, 2024 09:11 — with GitHub Actions Inactive
@lcauser-oqc lcauser-oqc merged commit de1ab83 into main Nov 11, 2024
20 checks passed
@lcauser-oqc lcauser-oqc deleted the feature/lc/benchmarking_tests branch November 11, 2024 11:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants