-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance regression checks: benchmarking tests #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcauser-oqc
temporarily deployed
to
applications - github
October 23, 2024 07:51
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
October 23, 2024 12:49
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
October 23, 2024 14:10
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
October 24, 2024 11:23
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
October 24, 2024 14:22
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
October 24, 2024 14:28
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
October 24, 2024 14:54
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
October 24, 2024 14:54
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
October 24, 2024 15:01
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
October 24, 2024 15:12
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
October 25, 2024 09:14
— with
GitHub Actions
Inactive
bgsach
reviewed
Oct 25, 2024
bgsach
reviewed
Oct 25, 2024
bgsach
reviewed
Oct 25, 2024
lcauser-oqc
temporarily deployed
to
applications - github
October 25, 2024 11:55
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
October 25, 2024 13:56
— with
GitHub Actions
Inactive
lcauser-oqc
changed the title
Benchmarks
Performance regression checks: benchmarking tests
Oct 25, 2024
lcauser-oqc
temporarily deployed
to
applications - github
October 25, 2024 14:02
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
October 25, 2024 14:54
— with
GitHub Actions
Inactive
lcauser-oqc
force-pushed
the
feature/lc/benchmarking_tests
branch
from
October 25, 2024 15:02
7708e82
to
a1d4f2a
Compare
lcauser-oqc
temporarily deployed
to
applications - github
October 25, 2024 15:02
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
October 28, 2024 15:07
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
October 28, 2024 18:15
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
October 30, 2024 11:20
— with
GitHub Actions
Inactive
lcauser-oqc
requested review from
keriksson-rosenqvist and
owen-oqc
as code owners
October 30, 2024 19:41
lcauser-oqc
temporarily deployed
to
applications - github
October 31, 2024 12:53
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
October 31, 2024 14:27
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
November 1, 2024 13:08
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
November 1, 2024 13:17
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
November 1, 2024 13:17
— with
GitHub Actions
Inactive
keriksson-rosenqvist
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lcauser-oqc
temporarily deployed
to
applications - github
November 4, 2024 15:24
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
November 4, 2024 15:24
— with
GitHub Actions
Inactive
bgsach
approved these changes
Nov 5, 2024
bgsach
temporarily deployed
to
applications - github
November 5, 2024 14:23
— with
GitHub Actions
Inactive
lcauser-oqc
temporarily deployed
to
applications - github
November 6, 2024 09:11
— with
GitHub Actions
Inactive
lcauser-oqc
force-pushed
the
feature/lc/benchmarking_tests
branch
from
November 11, 2024 11:40
8c2494e
to
215a6bd
Compare
lcauser-oqc
temporarily deployed
to
applications - github
November 11, 2024 11:40
— with
GitHub Actions
Inactive
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance regression checks when merging to main.
This first PR adds a number of performance benchmarks that will enable us to ensure that we do not introduce performance regressions to QAT.
pytest-benchmark
to allow us to run performance benchmarks.README
to explain how the benchmarks can be used.The workflow to automatically compare performance to main follows in #235.
Note: There are some temporary benchmark tests that are only there for demonstration purposes, and will be removed before merging.