-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance regression checks: workflow #235
Conversation
8c2494e
to
215a6bd
Compare
13579b3
to
89e444a
Compare
Performance Regression TestsPerformance changes detected in the following benchmarks: none Pusher: @lcauser-oqc, Action: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably needs updating because you moved the benchmarks folder out of tests?
Apart from that, looks good.
0814780
to
eb31bd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great to have this on PR flows. 👏
c76caf7
to
6e6f58a
Compare
6e6f58a
to
4e12847
Compare
Performance regression checks when merging to main.
#229 introduces a number of benchmarks that can be used to measure the performance of QAT. In this PR, we add a workflow that compares the performance to main.
jinja2
and is given as both a workflow summary and a comment in the PR.Note: there are temporary tests to demonstrate the report (see the comment below) that will be removed before merging to main. This is why the workflow currently fails. Had to delete old bot comments - this was a problem specific to this branch being automatically rebased onto main before having a change to update a workflow.