Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faddat/tweaks encountered along the way #9

Conversation

faddat
Copy link
Member

@faddat faddat commented Feb 25, 2024

context

And I might be wrong about this second part, but looking at where this value is used https://github.com/osmosis-labs/cometbft/blob/490dd752eb8a1a934542f70fdc8960594e06973b/blocksync/pool.go#L264-L268, it seems like because we are fetching blocks very far out, we just error and disregard them, so its completely wasted cycles AFAICT.

[pool.go](https://github.com/osmosis-labs/cometbft/blob/490dd752eb8a1a934542f70fdc8960594e06973b/blocksync/pool.go)
        if diff > maxDiffBetweenCurrentAndReceivedBlockHeight {
            pool.sendError(errors.New("peer sent us a block we didn't expect with a height too far ahead/behind"), peerID)
        }
        return
    }
Show more
<https://github.com/[osmosis-labs/cometbft](https://github.com/osmosis-labs/cometbft)|osmosis-labs/cometbft>osmosis-labs/cometbft | Added by https://notionalgroup.slack.com/services/B028F6EMYQM
21 replies


Jacob Gadikian
:spiral_calendar_pad:  [7 hours ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708862641221399?thread_ts=1708749103.552179&cid=CUB7CESLX)
Depending on where this is called, it could cause disconnection from that peer.


Jacob Gadikian
:spiral_calendar_pad:  [7 hours ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708862653674439?thread_ts=1708749103.552179&cid=CUB7CESLX)
When a peer accumulates errors it is put into a naughty lists, and disconnected from


Jacob Gadikian
:spiral_calendar_pad:  [6 hours ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708863032069109?thread_ts=1708749103.552179&cid=CUB7CESLX)
[@adam](https://notionalgroup.slack.com/team/U02RS0RBDJ6)
 is the cometbft fork you're linking to above compatible with the current osmosis release?


Jacob Gadikian
:spiral_calendar_pad:  [6 hours ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708863050326239?thread_ts=1708749103.552179&cid=CUB7CESLX)
becasue I can try to cherry pick the pool routine changes into it, or such.  I think it will also reduce ram/cpu use


adam
  [1 hour ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708880922051329?thread_ts=1708749103.552179&cid=CUB7CESLX)
Yeah it is compatible. Two changes should be made
Only fetch the next x blocks and respect this limit
when fetching blocks, maybe 50 blocks ahead of you, request from 3 or more peers and take the one that gets returned first
(edited)


adam
  [1 hour ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708880964930639?thread_ts=1708749103.552179&cid=CUB7CESLX)
This will make a large difference, paired with async pruning. These two problems fixes there will essentially never be a time when a node is syncing that it pauses for a couple of seconds
:100:
1



adam
  [1 hour ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708880989173939?thread_ts=1708749103.552179&cid=CUB7CESLX)
The pause is always one of these two issues, peer starving a block from you or your node is pruning


Jacob Gadikian
:spiral_calendar_pad:  [1 hour ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708881934727129?thread_ts=1708749103.552179&cid=CUB7CESLX)
yeah validators call "pauses for a couple of seconds" "the persistent peer issue"


Jacob Gadikian
:spiral_calendar_pad:  [1 hour ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708881939968479?thread_ts=1708749103.552179&cid=CUB7CESLX)
idk if you ever tried just having seeds


adam
  [1 hour ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708882640176529?thread_ts=1708749103.552179&cid=CUB7CESLX)
It still won’t help given we only fetch one block from one peer


adam
  [1 hour ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708882723949479?thread_ts=1708749103.552179&cid=CUB7CESLX)
So there is always a single point of failure. That paired with the fact that the settings only allow for a peer to have 20 pending requests, you are forced to have a breadth of peers you are requesting from, which eventually causes you to get stuck on one


Jacob Gadikian
:spiral_calendar_pad:  [1 hour ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708882782155919?thread_ts=1708749103.552179&cid=CUB7CESLX)
Huh well this will be fun.


Jacob Gadikian
:spiral_calendar_pad:  [1 hour ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708882821903249?thread_ts=1708749103.552179&cid=CUB7CESLX)
One of my earliest issues on the tenderment repository was actually the speed of block synchronization.  I was comparing to chains written in Dan larimers graphene thingy (very very boost libs and c++) and... Yeah we got completely smoked in the comparison


adam
  [1 hour ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708882944395199?thread_ts=1708749103.552179&cid=CUB7CESLX)
I think these two changes alone get us generally where we need to be, with future research on further improvements still being needed after
https://osmosis-network.slack.com/archives/CUB7CESLX/p1708880922051329?thread_ts=1708749103.552179&channel=CUB7CESLX&message_ts=1708880922.051329




adam
Yeah it is compatible. Two changes should be made
Only fetch the next x blocks and respect this limit
when fetching blocking, idk maybe 50 blocks ahead of you, request from 2 or 3 peers and take the one that gets returned first
(edited)
[From a thread in shared-tendermint](https://osmosis-network.slack.com/archives/CUB7CESLX/p1708880922051329?thread_ts=1708749103.552179&amp;channel=CUB7CESLX&amp;message_ts=1708880922.051329) | [Today at 7:08 PM](https://osmosis-network.slack.com/archives/CUB7CESLX/p1708880922051329?thread_ts=1708749103.552179&amp;channel=CUB7CESLX&amp;message_ts=1708880922.051329) | [View reply](https://osmosis-network.slack.com/archives/CUB7CESLX/p1708880922051329?thread_ts=1708749103.552179&amp;channel=CUB7CESLX&amp;message_ts=1708880922.051329)
:+1:
1



Jacob Gadikian
:spiral_calendar_pad:  [1 hour ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708883054305239?thread_ts=1708749103.552179&cid=CUB7CESLX)
Do you prefer this to be made against main and then backported to 37 or against 37 and then forward ported to main?


adam
  [1 hour ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708883143773779?thread_ts=1708749103.552179&cid=CUB7CESLX)
Osmosis likely will be on 37 for the foreseeable future until sdk 50 issues get worked out via dydx so selfishly I say the latter, but former is also fine!
:+1:
1



Jacob Gadikian
:spiral_calendar_pad:  [1 hour ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708883244539519?thread_ts=1708749103.552179&cid=CUB7CESLX)
Okay, you know it'll probably be easier to do 37, there won't be any concerns from vote extensions.  I tried to backport my pr, but it got pretty messy.


Jacob Gadikian
:spiral_calendar_pad:  [1 hour ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708883272072309?thread_ts=1708749103.552179&cid=CUB7CESLX)
Oh by the way I think I did succeed in getting you metrics for stuff like block size, by backporting.


adam
  [44 minutes ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708883635808589?thread_ts=1708749103.552179&cid=CUB7CESLX)
oh i was just able to print them in a println, the largest i saw was 195000bytes but would like to see if you saw differently


adam
  [44 minutes ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708883658999979?thread_ts=1708749103.552179&cid=CUB7CESLX)
(you can print the block.Size when you fetch from a peer and i just read from those)


Jacob Gadikian
:spiral_calendar_pad:  [33 minutes ago](https://notionalgroup.slack.com/archives/CUB7CESLX/p1708884344214839?thread_ts=1708749103.552179&cid=CUB7CESLX)
so, it gets subjective really around the tx results --  if it is just the proto stuff, I think your number sounds totally correct

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

mergify bot and others added 29 commits December 2, 2023 06:32
…etbft#1722)

* types: validate Validator#Address field (cometbft#1715)

* types: validate Validator#Address field

* fix TestProposerSelection3

* add a changelog entry

* fix two more tests

* Update .changelog/unreleased/improvements/1715-validate-validator-address

Co-authored-by: Thane Thomson <connect@thanethomson.com>

---------

Co-authored-by: Thane Thomson <connect@thanethomson.com>
(cherry picked from commit 63fe7bf)

# Conflicts:
#	internal/state/store_test.go
#	internal/store/store_test.go

* fix conflicts

* fix test

* golint

---------

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
…t#1730) (cometbft#1746)

* fix: increase abci socket message size limit to 2GB (cometbft#1730)

* fix: increase abci socket message size to 2GB

* fix: added .changelog

* Update .changelog/unreleased/improvements/1730-increase-abci-socket-message-size-limit

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>

* fix: use MaxInt32 as message size for 32-bit systems

* Update .changelog/unreleased/improvements/1730-increase-abci-socket-message-size-limit

---------

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Thane Thomson <connect@thanethomson.com>
(cherry picked from commit 092b918)

* Rename 1730-increase-abci-socket-message-size-limit to 1730-increase-abci-socket-message-size-limit.md

---------

Co-authored-by: Troy Kessler <43882936+troykessler@users.noreply.github.com>
Co-authored-by: Thane Thomson <connect@thanethomson.com>
* fix: The calculation method of tx size returned by calling proxyapp should be consistent with that of mempool

* Revert CHANGELOG.md

entries should go into .changelog

---------

Co-authored-by: lasaro <lasaro@informal.systems>
Co-authored-by: lasaro <lasaro@gmail.com>
(cherry picked from commit eb5d9ce)

Co-authored-by: leven <112051166+lx-xiang@users.noreply.github.com>
* Update CODE_OF_CONDUCT.md

Updated the contact email to an `informal.systems` one, and some nits.

* Update CODE_OF_CONDUCT.md

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>

---------

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
(cherry picked from commit bde1111)

Co-authored-by: Adi Seredinschi <adizere@gmail.com>
…ns (backport cometbft#1756) (cometbft#1774)

* [e2e] Fixes prepareProposal not to return oversized set of transactions (cometbft#1756)

* Fixes prepareProposal not to return oversized set of transactions

* Update test/e2e/app/app.go

* Fix linting error

* add changelog entry

* Avoid marshalling the tx twice

* removing unneeded changelog

(cherry picked from commit 0bf3f0a)

# Conflicts:
#	test/e2e/app/app.go

* Solve conflict

---------

Co-authored-by: lasaro <lasaro@informal.systems>
…1760)

* Add test missing in cometbft#1687 (cometbft#1712)

* Experimenting the fix from lx-xiang

* Fixes name in the example

* Reverts fix, so it is merged from the proper branch.

* Adds a test that fails because the validate is wrong and accepts a block that is larger than it should.

* Add changelog for the original PR

* Update internal/state/execution_test.go

(cherry picked from commit ce0215c)

# Conflicts:
#	abci/example/kvstore/kvstore.go

* Reverting change in ABCI type name

* Update type of test function

* solving conflict in test

* Solve conflicts

* remove unused variable

* Fix mocking function

* revert signature change

* Apply type cast

* Apply type cast

---------

Co-authored-by: lasaro <lasaro@informal.systems>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/stale](https://github.com/actions/stale) from 8 to 9.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v8...v9)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…LightTrusting` (cometbft#1806)

* [e2e] Repro evidence bug: not checking all signatures

* Introduce `countAllSignatures` in `VerifyCommitLight` & `VerifyCommitLightTrusting`

* Revert unneded change

* Addressed @insumity's comments

---------

Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
(cherry picked from commit 437391a)

Co-authored-by: Sergio Mena <sergio@informal.systems>
* use latest golangci-lint-action

* make the linter run on workflow changes too

* disable 3 linters for now

until we fix all the errors

* comment out goconst as well

* reenable depguard
Otherwise, the events from app's BeginBlock won't be fired.

Closes cometbft#1468

Co-authored-by: forcodedancing <just.haha.it@gmail.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ft#1864)

* Updates go crypto package to v0.17.0 (cometbft#1859)

(cherry picked from commit fd87fda)

# Conflicts:
#	go.mod
#	go.sum

* Solving conflict

---------

Co-authored-by: lasaro <lasaro@informal.systems>
…cometbft#1871)

* Allow blocksync to not verify all signatures (cometbft#1858)

* Blocksync can skip sigs

* bump

(cherry picked from commit 9446e31)

# Conflicts:
#	blocksync/reactor.go

* Revert "Allow blocksync to not verify all signatures (cometbft#1858)"

This reverts commit 4f2a211.

* Allow blocksync to not verify all signatures (cometbft#1858)

* Blocksync can skip sigs

* bump

---------

Co-authored-by: Sergio Mena <sergio@informal.systems>
…1895)

* docs: Fix Discord links in README (cometbft#1874)

Signed-off-by: Thane Thomson <connect@thanethomson.com>
(cherry picked from commit f72d930)

# Conflicts:
#	README.md

* fix conflicts

---------

Co-authored-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
…metbft#2168)

Bumps
[bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action)
from 1.28.1 to 1.29.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/bufbuild/buf-setup-action/releases">bufbuild/buf-setup-action's
releases</a>.</em></p>
<blockquote>
<h2>v1.29.0</h2>
<p>Release v1.29.0</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/bufbuild/buf-setup-action/commit/88db93f5d74ffa329bb43e42aa95cd822697d214"><code>88db93f</code></a>
Release v1.29.0 (<a
href="https://redirect.github.com/bufbuild/buf-setup-action/issues/181">#181</a>)</li>
<li>See full diff in <a
href="https://github.com/bufbuild/buf-setup-action/compare/v1.28.1...v1.29.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=bufbuild/buf-setup-action&package-manager=github_actions&previous-version=1.28.1&new-version=1.29.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ometbft#2167)

Bumps
[slackapi/slack-github-action](https://github.com/slackapi/slack-github-action)
from 1.24.0 to 1.25.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/slackapi/slack-github-action/releases">slackapi/slack-github-action's
releases</a>.</em></p>
<blockquote>
<h2>Slack Send V1.25.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update payload integration test to escape invalid characters by <a
href="https://github.com/hello-ashleyintech"><code>@​hello-ashleyintech</code></a>
in <a
href="https://redirect.github.com/slackapi/slack-github-action/pull/207">slackapi/slack-github-action#207</a></li>
<li><a
href="https://redirect.github.com/slackapi/slack-github-action/issues/204">#204</a>:
Handle proxies when using Slack WebClient by <a
href="https://github.com/raihle"><code>@​raihle</code></a> in <a
href="https://redirect.github.com/slackapi/slack-github-action/pull/205">slackapi/slack-github-action#205</a></li>
<li>README: clarify limitations to workflow builder approach by <a
href="https://github.com/ryan-williams"><code>@​ryan-williams</code></a>
in <a
href="https://redirect.github.com/slackapi/slack-github-action/pull/228">slackapi/slack-github-action#228</a></li>
<li>Add instructions for developing with a local version of the action
by <a href="https://github.com/zimeg"><code>@​zimeg</code></a> in <a
href="https://redirect.github.com/slackapi/slack-github-action/pull/250">slackapi/slack-github-action#250</a></li>
<li>Pass secrets to approved workflow jobs by <a
href="https://github.com/zimeg"><code>@​zimeg</code></a> in <a
href="https://redirect.github.com/slackapi/slack-github-action/pull/258">slackapi/slack-github-action#258</a></li>
<li>build(node): bump the runtime version to node 20 by <a
href="https://github.com/zimeg"><code>@​zimeg</code></a> in <a
href="https://redirect.github.com/slackapi/slack-github-action/pull/267">slackapi/slack-github-action#267</a></li>
<li>ci(security): require access checks to pass before running unit
tests by <a href="https://github.com/zimeg"><code>@​zimeg</code></a> in
<a
href="https://redirect.github.com/slackapi/slack-github-action/pull/279">slackapi/slack-github-action#279</a></li>
<li>ci(security): check for pull_request_target events in the access
check by <a href="https://github.com/zimeg"><code>@​zimeg</code></a> in
<a
href="https://redirect.github.com/slackapi/slack-github-action/pull/282">slackapi/slack-github-action#282</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/raihle"><code>@​raihle</code></a> made
their first contribution in <a
href="https://redirect.github.com/slackapi/slack-github-action/pull/205">slackapi/slack-github-action#205</a></li>
<li><a
href="https://github.com/ryan-williams"><code>@​ryan-williams</code></a>
made their first contribution in <a
href="https://redirect.github.com/slackapi/slack-github-action/pull/228">slackapi/slack-github-action#228</a></li>
<li><a href="https://github.com/zimeg"><code>@​zimeg</code></a> made
their first contribution in <a
href="https://redirect.github.com/slackapi/slack-github-action/pull/250">slackapi/slack-github-action#250</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/slackapi/slack-github-action/compare/v1.24.0...v1.25.0">https://github.com/slackapi/slack-github-action/compare/v1.24.0...v1.25.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/slackapi/slack-github-action/commit/6c661ce58804a1a20f6dc5fbee7f0381b469e001"><code>6c661ce</code></a>
Automatic compilation</li>
<li><a
href="https://github.com/slackapi/slack-github-action/commit/2a8087d4af6f83146a87539a70defe909fe6dbe6"><code>2a8087d</code></a>
v1.25.0</li>
<li><a
href="https://github.com/slackapi/slack-github-action/commit/a678e5895f7ecf8ceef4ae0d60ff94943d6c559d"><code>a678e58</code></a>
ci(security): check for pull_request_target events in the access check
(<a
href="https://redirect.github.com/slackapi/slack-github-action/issues/282">#282</a>)</li>
<li><a
href="https://github.com/slackapi/slack-github-action/commit/84a8f7dc295123812a19af49e72b54768921b60e"><code>84a8f7d</code></a>
ci(security): require access checks to pass before running unit tests
(<a
href="https://redirect.github.com/slackapi/slack-github-action/issues/279">#279</a>)</li>
<li><a
href="https://github.com/slackapi/slack-github-action/commit/f6aff2ffc901ab1d21ccbaf09093093f979714f1"><code>f6aff2f</code></a>
Bump eslint from 8.54.0 to 8.56.0 (<a
href="https://redirect.github.com/slackapi/slack-github-action/issues/275">#275</a>)</li>
<li><a
href="https://github.com/slackapi/slack-github-action/commit/372e934439356661e2a5ae575863e845135ff2d6"><code>372e934</code></a>
Bump eslint-plugin-import from 2.29.0 to 2.29.1 (<a
href="https://redirect.github.com/slackapi/slack-github-action/issues/274">#274</a>)</li>
<li><a
href="https://github.com/slackapi/slack-github-action/commit/bac28df31139b168d2feabae98f35ae251d4b96b"><code>bac28df</code></a>
Bump <code>@​slack/web-api</code> from 6.9.1 to 6.11.1 (<a
href="https://redirect.github.com/slackapi/slack-github-action/issues/277">#277</a>)</li>
<li><a
href="https://github.com/slackapi/slack-github-action/commit/0474a451d1ec1d933ca8772954195c0f604f059f"><code>0474a45</code></a>
Unit tests in GitHub CI should test the PR/branch (<a
href="https://redirect.github.com/slackapi/slack-github-action/issues/276">#276</a>)</li>
<li><a
href="https://github.com/slackapi/slack-github-action/commit/34ae0b46d6d643ee3739caa37f4d4c88bb8b5b24"><code>34ae0b4</code></a>
Bump <code>@​actions/github</code> from 5.1.1 to 6.0.0 (<a
href="https://redirect.github.com/slackapi/slack-github-action/issues/265">#265</a>)</li>
<li><a
href="https://github.com/slackapi/slack-github-action/commit/e7f384011cbed2dde5150ed0c2ccb2b4f39835b0"><code>e7f3840</code></a>
Bump whatwg-url from 13.0.0 to 14.0.0 (<a
href="https://redirect.github.com/slackapi/slack-github-action/issues/263">#263</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/slackapi/slack-github-action/compare/v1.24.0...v1.25.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=slackapi/slack-github-action&package-manager=github_actions&previous-version=1.24.0&new-version=1.25.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…cometbft#2166)

Bumps
[styfle/cancel-workflow-action](https://github.com/styfle/cancel-workflow-action)
from 0.12.0 to 0.12.1.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ckport cometbft#2253) (cometbft#2256)

This is an automatic backport of pull request cometbft#2253 done by
[Mergify](https://mergify.com).
Cherry-pick of db7a70c has failed:
```
On branch mergify/bp/v0.37.x/pr-2253
Your branch is up to date with 'origin/v0.37.x'.

You are currently cherry-picking commit db7a70c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   go.mod
	both modified:   go.sum

no changes added to commit (use "git add" and/or "git commit -a")
```


To fix up this pull request, you can check it out locally. See
documentation:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mikhail Zabaluev <mikhail@informal.systems>
…ocks (backport cometbft#1408) (cometbft#2140)

This is an automatic backport of pull request cometbft#1408 done by
[Mergify](https://mergify.com).
Cherry-pick of 28ad4d2 has failed:
```
On branch mergify/bp/v0.37.x/pr-1408
Your branch is up to date with 'origin/v0.37.x'.

You are currently cherry-picking commit 28ad4d2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   consensus/state.go
	modified:   crypto/merkle/proof.go
	modified:   evidence/pool_test.go
	modified:   state/execution_test.go
	modified:   types/part_set.go
	modified:   types/part_set_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   internal/consensus/errors.go
	deleted by us:   internal/consensus/state_test.go
	deleted by us:   internal/state/store_test.go
	deleted by us:   internal/store/store_test.go
	both modified:   types/event_bus_test.go

```


To fix up this pull request, you can check it out locally. See
documentation:
https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

---------

Co-authored-by: Daniel <daniel.cason@informal.systems>
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
…#2297)

Bumps
[golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action)
from 3 to 4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/golangci/golangci-lint-action/releases">golangci/golangci-lint-action's
releases</a>.</em></p>
<blockquote>
<h2>v4.0.0</h2>
<!-- raw HTML omitted -->
<h2>What's Changed</h2>
<h3>Documentation</h3>
<ul>
<li>docs: update examples by <a
href="https://github.com/KunalSin9h"><code>@​KunalSin9h</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/826">golangci/golangci-lint-action#826</a></li>
<li>docs: update section about GitHub Annotations by <a
href="https://github.com/JustinDFuller"><code>@​JustinDFuller</code></a>
in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/931">golangci/golangci-lint-action#931</a></li>
</ul>
<h3>Dependencies</h3>
<ul>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.3.0 to 6.4.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/829">golangci/golangci-lint-action#829</a></li>
<li>build(deps-dev): bump eslint-plugin-import from 2.28.0 to 2.28.1 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/830">golangci/golangci-lint-action#830</a></li>
<li>build(deps): bump <code>@​types/node</code> from 20.5.0 to 20.5.1 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/827">golangci/golangci-lint-action#827</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
6.3.0 to 6.4.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/831">golangci/golangci-lint-action#831</a></li>
<li>build(deps-dev): bump prettier from 3.0.1 to 3.0.2 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/828">golangci/golangci-lint-action#828</a></li>
<li>build(deps): bump <code>@​types/node</code> from 20.5.1 to 20.5.7 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/833">golangci/golangci-lint-action#833</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.4.0 to 6.4.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/834">golangci/golangci-lint-action#834</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
6.4.0 to 6.4.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/835">golangci/golangci-lint-action#835</a></li>
<li>build(deps-dev): bump eslint from 8.47.0 to 8.48.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/837">golangci/golangci-lint-action#837</a></li>
<li>build(deps-dev): bump typescript from 5.1.6 to 5.2.2 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/836">golangci/golangci-lint-action#836</a></li>
<li>build(deps): bump <code>@​types/semver</code> from 7.5.0 to 7.5.1 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/838">golangci/golangci-lint-action#838</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.4.1 to 6.5.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/839">golangci/golangci-lint-action#839</a></li>
<li>build(deps-dev): bump prettier from 3.0.2 to 3.0.3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/842">golangci/golangci-lint-action#842</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
6.4.1 to 6.5.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/840">golangci/golangci-lint-action#840</a></li>
<li>build(deps): bump <code>@​types/node</code> from 20.5.7 to 20.5.9 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/841">golangci/golangci-lint-action#841</a></li>
<li>chore: bump to use node20 runtime, actions/checkout to v4 by <a
href="https://github.com/chenrui333"><code>@​chenrui333</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/843">golangci/golangci-lint-action#843</a></li>
<li>build(deps): bump actions/checkout from 3 to 4 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/845">golangci/golangci-lint-action#845</a></li>
<li>build(deps-dev): bump eslint from 8.48.0 to 8.49.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/846">golangci/golangci-lint-action#846</a></li>
<li>build(deps): bump <code>@​types/node</code> from 20.5.9 to 20.6.0 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/847">golangci/golangci-lint-action#847</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
6.5.0 to 6.6.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/848">golangci/golangci-lint-action#848</a></li>
<li>build(deps-dev): bump <code>@​vercel/ncc</code> from 0.36.1 to
0.38.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/850">golangci/golangci-lint-action#850</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.5.0 to 6.6.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/849">golangci/golangci-lint-action#849</a></li>
<li>build(deps): bump <code>@​types/semver</code> from 7.5.1 to 7.5.2 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/853">golangci/golangci-lint-action#853</a></li>
<li>build(deps): bump <code>@​types/tmp</code> from 0.2.3 to 0.2.4 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/854">golangci/golangci-lint-action#854</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.6.0 to 6.7.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/855">golangci/golangci-lint-action#855</a></li>
<li>build(deps): bump <code>@​types/node</code> from 20.6.0 to 20.6.2 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/857">golangci/golangci-lint-action#857</a></li>
<li>build(deps): bump <code>@​actions/core</code> from 1.10.0 to 1.10.1
by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>
in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/856">golangci/golangci-lint-action#856</a></li>
<li>build(deps-dev): bump eslint from 8.49.0 to 8.50.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/859">golangci/golangci-lint-action#859</a></li>
<li>build(deps): bump <code>@​types/node</code> from 20.6.2 to 20.6.5 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/860">golangci/golangci-lint-action#860</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
6.6.0 to 6.7.2 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/861">golangci/golangci-lint-action#861</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.7.0 to 6.7.2 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/862">golangci/golangci-lint-action#862</a></li>
<li>build(deps): bump <code>@​types/semver</code> from 7.5.2 to 7.5.3 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/864">golangci/golangci-lint-action#864</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.7.2 to 6.7.3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/865">golangci/golangci-lint-action#865</a></li>
<li>build(deps): bump <code>@​types/node</code> from 20.6.5 to 20.8.0 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/867">golangci/golangci-lint-action#867</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
6.7.2 to 6.7.3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/866">golangci/golangci-lint-action#866</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
6.7.3 to 6.7.4 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/868">golangci/golangci-lint-action#868</a></li>
<li>build(deps): bump <code>@​types/node</code> from 20.8.0 to 20.8.3 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/869">golangci/golangci-lint-action#869</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.7.3 to 6.7.4 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/870">golangci/golangci-lint-action#870</a></li>
<li>build(deps-dev): bump eslint from 8.50.0 to 8.51.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/871">golangci/golangci-lint-action#871</a></li>
<li>build(deps): bump <code>@​actions/http-client</code> from 2.1.1 to
2.2.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/872">golangci/golangci-lint-action#872</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
6.7.4 to 6.7.5 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/874">golangci/golangci-lint-action#874</a></li>
<li>build(deps): bump <code>@​types/node</code> from 20.8.3 to 20.8.6 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/875">golangci/golangci-lint-action#875</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/3cfe3a4abbb849e10058ce4af15d205b6da42804"><code>3cfe3a4</code></a>
build(deps): bump <code>@​actions/cache</code> from 3.2.3 to 3.2.4 (<a
href="https://redirect.github.com/golangci/golangci-lint-action/issues/963">#963</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/cbc59cf0d18a8aa6b4806cab8d5a6ad3622f57fe"><code>cbc59cf</code></a>
build(deps-dev): bump prettier from 3.2.4 to 3.2.5 (<a
href="https://redirect.github.com/golangci/golangci-lint-action/issues/960">#960</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/459a04b021b544b77372de9a6e429e0d3c136fac"><code>459a04b</code></a>
build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.19.1 to 6.20.0 ...</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/e2315b67db0fd76598007338449373a42c572b25"><code>e2315b6</code></a>
build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
6.19.1 to 6.20.0 (<a
href="https://redirect.github.com/golangci/golangci-lint-action/issues/961">#961</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/d6173a45d0441c7db097b6014862dde0ddc9b579"><code>d6173a4</code></a>
build(deps): bump <code>@​types/node</code> from 20.11.10 to 20.11.16
(<a
href="https://redirect.github.com/golangci/golangci-lint-action/issues/962">#962</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/0e8f5bf773dd8000d6aeb01936f3090976982f33"><code>0e8f5bf</code></a>
build(deps): bump <code>@​types/node</code> from 20.11.5 to 20.11.10 (<a
href="https://redirect.github.com/golangci/golangci-lint-action/issues/958">#958</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/349d20632dbaed38f0a492cc991152e3d351e854"><code>349d206</code></a>
build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.19.0 to 6.19.1 ...</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/2221aee28499deb9551e403a0d876df4b0e70067"><code>2221aee</code></a>
build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
6.18.1 to 6.19.1 (<a
href="https://redirect.github.com/golangci/golangci-lint-action/issues/954">#954</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/3b44ae5b24a084588d4051d37ccb95e8a709a9a3"><code>3b44ae5</code></a>
build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.18.1 to 6.19.0 ...</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/323b871bbc74bdc20959d979cb52c68910b77f37"><code>323b871</code></a>
build(deps-dev): bump prettier from 3.2.2 to 3.2.4 (<a
href="https://redirect.github.com/golangci/golangci-lint-action/issues/950">#950</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/golangci/golangci-lint-action/compare/v3...v4">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golangci/golangci-lint-action&package-manager=github_actions&previous-version=3&new-version=4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ometbft#2339)

This is an automatic backport of pull request cometbft#2331 done by
[Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Copy link

github-actions bot commented Mar 7, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Mar 7, 2024
@github-actions github-actions bot closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants