Faddat/tweaks encountered along the way #9

…etbft#1722) * types: validate Validator#Address field (cometbft#1715) * types: validate Validator#Address field * fix TestProposerSelection3 * add a changelog entry * fix two more tests * Update .changelog/unreleased/improvements/1715-validate-validator-address Co-authored-by: Thane Thomson <connect@thanethomson.com> --------- Co-authored-by: Thane Thomson <connect@thanethomson.com> (cherry picked from commit 63fe7bf) # Conflicts: # internal/state/store_test.go # internal/store/store_test.go * fix conflicts * fix test * golint --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>

…t#1730) (cometbft#1746) * fix: increase abci socket message size limit to 2GB (cometbft#1730) * fix: increase abci socket message size to 2GB * fix: added .changelog * Update .changelog/unreleased/improvements/1730-increase-abci-socket-message-size-limit Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> * fix: use MaxInt32 as message size for 32-bit systems * Update .changelog/unreleased/improvements/1730-increase-abci-socket-message-size-limit --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> Co-authored-by: Thane Thomson <connect@thanethomson.com> (cherry picked from commit 092b918) * Rename 1730-increase-abci-socket-message-size-limit to 1730-increase-abci-socket-message-size-limit.md --------- Co-authored-by: Troy Kessler <43882936+troykessler@users.noreply.github.com> Co-authored-by: Thane Thomson <connect@thanethomson.com>

* fix: The calculation method of tx size returned by calling proxyapp should be consistent with that of mempool * Revert CHANGELOG.md entries should go into .changelog --------- Co-authored-by: lasaro <lasaro@informal.systems> Co-authored-by: lasaro <lasaro@gmail.com> (cherry picked from commit eb5d9ce) Co-authored-by: leven <112051166+lx-xiang@users.noreply.github.com>

* Update CODE_OF_CONDUCT.md Updated the contact email to an `informal.systems` one, and some nits. * Update CODE_OF_CONDUCT.md Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> (cherry picked from commit bde1111) Co-authored-by: Adi Seredinschi <adizere@gmail.com>

…ns (backport cometbft#1756) (cometbft#1774) * [e2e] Fixes prepareProposal not to return oversized set of transactions (cometbft#1756) * Fixes prepareProposal not to return oversized set of transactions * Update test/e2e/app/app.go * Fix linting error * add changelog entry * Avoid marshalling the tx twice * removing unneeded changelog (cherry picked from commit 0bf3f0a) # Conflicts: # test/e2e/app/app.go * Solve conflict --------- Co-authored-by: lasaro <lasaro@informal.systems>

…1760) * Add test missing in cometbft#1687 (cometbft#1712) * Experimenting the fix from lx-xiang * Fixes name in the example * Reverts fix, so it is merged from the proper branch. * Adds a test that fails because the validate is wrong and accepts a block that is larger than it should. * Add changelog for the original PR * Update internal/state/execution_test.go (cherry picked from commit ce0215c) # Conflicts: # abci/example/kvstore/kvstore.go * Reverting change in ABCI type name * Update type of test function * solving conflict in test * Solve conflicts * remove unused variable * Fix mocking function * revert signature change * Apply type cast * Apply type cast --------- Co-authored-by: lasaro <lasaro@informal.systems>

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/stale](https://github.com/actions/stale) from 8 to 9. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v8...v9) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

@insumity

…LightTrusting` (cometbft#1806) * [e2e] Repro evidence bug: not checking all signatures * Introduce `countAllSignatures` in `VerifyCommitLight` & `VerifyCommitLightTrusting` * Revert unneded change * Addressed @insumity's comments --------- Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>

(cherry picked from commit 437391a) Co-authored-by: Sergio Mena <sergio@informal.systems>

* use latest golangci-lint-action * make the linter run on workflow changes too * disable 3 linters for now until we fix all the errors * comment out goconst as well * reenable depguard

Otherwise, the events from app's BeginBlock won't be fired. Closes cometbft#1468 Co-authored-by: forcodedancing <just.haha.it@gmail.com>

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ft#1864) * Updates go crypto package to v0.17.0 (cometbft#1859) (cherry picked from commit fd87fda) # Conflicts: # go.mod # go.sum * Solving conflict --------- Co-authored-by: lasaro <lasaro@informal.systems>

…cometbft#1871) * Allow blocksync to not verify all signatures (cometbft#1858) * Blocksync can skip sigs * bump (cherry picked from commit 9446e31) # Conflicts: # blocksync/reactor.go * Revert "Allow blocksync to not verify all signatures (cometbft#1858)" This reverts commit 4f2a211. * Allow blocksync to not verify all signatures (cometbft#1858) * Blocksync can skip sigs * bump --------- Co-authored-by: Sergio Mena <sergio@informal.systems>

…1895) * docs: Fix Discord links in README (cometbft#1874) Signed-off-by: Thane Thomson <connect@thanethomson.com> (cherry picked from commit f72d930) # Conflicts: # README.md * fix conflicts --------- Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>

…metbft#2168) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.28.1 to 1.29.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bufbuild/buf-setup-action/releases">bufbuild/buf-setup-action's releases</a>.</em></p> <blockquote> <h2>v1.29.0</h2> <p>Release v1.29.0</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/bufbuild/buf-setup-action/commit/88db93f5d74ffa329bb43e42aa95cd822697d214"><code>88db93f</code></a> Release v1.29.0 (<a href="https://redirect.github.com/bufbuild/buf-setup-action/issues/181">#181</a>)</li> <li>See full diff in <a href="https://github.com/bufbuild/buf-setup-action/compare/v1.28.1...v1.29.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=bufbuild/buf-setup-action&package-manager=github_actions&previous-version=1.28.1&new-version=1.29.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…cometbft#2166) Bumps [styfle/cancel-workflow-action](https://github.com/styfle/cancel-workflow-action) from 0.12.0 to 0.12.1. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ckport cometbft#2253) (cometbft#2256) This is an automatic backport of pull request cometbft#2253 done by [Mergify](https://mergify.com). Cherry-pick of db7a70c has failed: ``` On branch mergify/bp/v0.37.x/pr-2253 Your branch is up to date with 'origin/v0.37.x'. You are currently cherry-picking commit db7a70c. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Unmerged paths: (use "git add <file>..." to mark resolution) both modified: go.mod both modified: go.sum no changes added to commit (use "git add" and/or "git commit -a") ``` To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mikhail Zabaluev <mikhail@informal.systems>

…ocks (backport cometbft#1408) (cometbft#2140) This is an automatic backport of pull request cometbft#1408 done by [Mergify](https://mergify.com). Cherry-pick of 28ad4d2 has failed: ``` On branch mergify/bp/v0.37.x/pr-1408 Your branch is up to date with 'origin/v0.37.x'. You are currently cherry-picking commit 28ad4d2. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Changes to be committed: modified: consensus/state.go modified: crypto/merkle/proof.go modified: evidence/pool_test.go modified: state/execution_test.go modified: types/part_set.go modified: types/part_set_test.go Unmerged paths: (use "git add/rm <file>..." as appropriate to mark resolution) deleted by us: internal/consensus/errors.go deleted by us: internal/consensus/state_test.go deleted by us: internal/state/store_test.go deleted by us: internal/store/store_test.go both modified: types/event_bus_test.go ``` To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> --------- Co-authored-by: Daniel <daniel.cason@informal.systems> Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>

…ometbft#2339) This is an automatic backport of pull request cometbft#2331 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Andy Nogueira <me@andynogueira.dev>

…e-from-upstream

This reverts commit 4107396.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Faddat/tweaks encountered along the way #9

Faddat/tweaks encountered along the way #9

Commits on Dec 2, 2023

Commits on Dec 5, 2023

Commits on Dec 7, 2023

Commits on Dec 8, 2023

Commits on Dec 11, 2023

Commits on Dec 13, 2023

Commits on Dec 18, 2023

Commits on Dec 19, 2023

Commits on Dec 20, 2023

Commits on Jan 4, 2024

Commits on Jan 29, 2024

Commits on Feb 7, 2024

Commits on Feb 9, 2024

Commits on Feb 12, 2024

Commits on Feb 14, 2024

Commits on Feb 25, 2024