-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spawn vehicle at requested orientation #143
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
|
Upstream's forward-port was merged. After tonight's nightlies are built, we should retrigger CI here. |
Ahh last night's https://build.osrfoundation.org/job/ign-gazebo7-debbuilder/159/ |
Yay, the latest nightlies are out and CI is 🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these docs.
Part of
Requires
This is a subset of
Make use of the roll, pitch and heading fields on the init message when spawning a vehicle.
I also changed the test to run paused, so we don't have the physics affecting the spawn pose and we can check it more precisely.
This takes an alternative approach to #81. Instead of rotating the model to face North by default, we introduce offsets when receiving spawn commands. This means we must be mindful of the fact that the vehicle faces West by default all the time when looking at poses, which is extremely error prone. I'd much rather change the model to match NED / FSK by default, but as explained in #48 (comment), there are physics issues with using a Z-down model that we'll need more time to track down.