Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn vehicle at requested orientation #143

Merged
merged 4 commits into from
Feb 3, 2022
Merged

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jan 12, 2022

Part of

Requires

This is a subset of


Make use of the roll, pitch and heading fields on the init message when spawning a vehicle.

I also changed the test to run paused, so we don't have the physics affecting the spawn pose and we can check it more precisely.

This takes an alternative approach to #81. Instead of rotating the model to face North by default, we introduce offsets when receiving spawn commands. This means we must be mindful of the fact that the vehicle faces West by default all the time when looking at poses, which is extremely error prone. I'd much rather change the model to match NED / FSK by default, but as explained in #48 (comment), there are physics issues with using a Z-down model that we'll need more time to track down.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina self-assigned this Jan 12, 2022
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jan 12, 2022
@chapulina chapulina marked this pull request as draft January 12, 2022 16:32
@chapulina
Copy link
Contributor Author

chapulina commented Jan 21, 2022

I forgot that the orientation is in NED, so this can't escape #81 . See updated description above.

@chapulina chapulina closed this Jan 21, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina reopened this Jan 21, 2022
@chapulina chapulina marked this pull request as ready for review January 21, 2022 02:17
@chapulina chapulina requested a review from arjo129 January 22, 2022 02:16
@chapulina
Copy link
Contributor Author

Upstream's forward-port was merged. After tonight's nightlies are built, we should retrigger CI here.

@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Jan 26, 2022
@caguero caguero mentioned this pull request Jan 26, 2022
39 tasks
@chapulina
Copy link
Contributor Author

Ahh last night's ign-gazebo7 nightly failed:

https://build.osrfoundation.org/job/ign-gazebo7-debbuilder/159/

@chapulina
Copy link
Contributor Author

Yay, the latest nightlies are out and CI is 🟢

Copy link
Member

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these docs.

@arjo129 arjo129 merged commit 9f694be into main Feb 3, 2022
@arjo129 arjo129 deleted the chapulina/spawn_orientation branch February 3, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants