Skip to content

Added Cmat in hydrodynamic forces equation#466

Closed
rmvanarse wants to merge 3 commits intogazebo_classicfrom
rmvanarse/add_cmat_hydrodymanics
Closed

Added Cmat in hydrodynamic forces equation#466
rmvanarse wants to merge 3 commits intogazebo_classicfrom
rmvanarse/add_cmat_hydrodymanics

Conversation

@rmvanarse
Copy link

This PR modifies the hydrodynamic forces equation in usv_gazebo_dynamics_plugin.cc to include the Coriolis centripetal matrix for added mass, Cmat.

As mentioned in #441, the model used in the code does not match the Theory of operation (see eq. 1).

Note: There also seem to be differences in the terms present in Cmat in Theory of operation, this paper and this definition. These differences have not been addressed in this PR.

Need to verify if switching to this model is causing any unexpected behaviour in the USV. Do you remember if Cmat was purposely omitted, and if so, the reason for doing so?

@rmvanarse rmvanarse requested review from bsb808 and caguero July 4, 2022 16:21
@rmvanarse rmvanarse marked this pull request as ready for review July 8, 2022 15:03
Copy link

@acxz acxz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the Coriolis hydro forces will be great to increase the fidelity of VRX. If users do not want to simulate these forces, the Coriolis params can always be set to zero.

@caguero
Copy link
Collaborator

caguero commented Jun 2, 2025

@rmvanarse , we got some time to help with your contribution. Are you willing to retarget it to the jazzy branch?

@rmvanarse rmvanarse changed the base branch from gazebo_classic to jazzy June 7, 2025 13:30
@rmvanarse
Copy link
Author

rmvanarse commented Jun 7, 2025

Hi @caguero , would you like me to rebase over jazzy? I can also re-open a separate PR with the same changes if that's easier and there aren't any other changes.
Is there a jazzy equivalent of the file I had changed?

@caguero
Copy link
Collaborator

caguero commented Jun 9, 2025

Hi @caguero , would you like me to rebase over jazzy? I can also re-open a separate PR with the same changes if that's easier and there aren't any other changes. Is there a jazzy equivalent of the file I had changed?

Whatever it's easier for you works for us :)

I think the hydrodynamics plugin should be pretty much the same.

@caguero caguero changed the base branch from jazzy to gazebo_classic June 24, 2025 18:18
@caguero
Copy link
Collaborator

caguero commented Jun 24, 2025

See #829

@caguero caguero closed this Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants