Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ast): estree compat Property #8974

Merged
merged 1 commit into from
Feb 9, 2025
Merged

fix(ast): estree compat Property #8974

merged 1 commit into from
Feb 9, 2025
+15 −12,889

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Feb 8, 2025 •
edited
Loading

Part of #2854

-Positive Passed: 16040/44293 (36.21%)
+Positive Passed: 28924/44293 (65.30%)

@github-actions github-actions bot added the A-ast Area - AST label Feb 8, 2025
@hi-ogawa hi-ogawa mentioned this pull request Feb 8, 2025
Merged
@hi-ogawa Graphite App
Copy link
Contributor Author

hi-ogawa commented Feb 8, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Feb 8, 2025
Merged
Merged
@hi-ogawa hi-ogawa changed the title fix: estree compat ObjectProperty -> Property fix(ast): estree compat Property Feb 8, 2025
@github-actions github-actions bot added the C-bug Category - Bug label Feb 8, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 8, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8974 will not alter performance

Comparing fix-ast-estree-property (2ee1d6c) with main (801d78e)

Summary

✅ 33 untouched benchmarks

@hi-ogawa hi-ogawa mentioned this pull request Feb 8, 2025
Merged
@hi-ogawa hi-ogawa changed the base branch from ast-estree-unary-prefix to graphite-base/8974 February 8, 2025 07:22
@hi-ogawa hi-ogawa force-pushed the fix-ast-estree-property branch from fb5055c to f710e55 Compare February 8, 2025 07:22
@hi-ogawa hi-ogawa force-pushed the fix-ast-estree-property branch from 72b2c96 to 25e33e6 Compare February 9, 2025 02:38
@hi-ogawa hi-ogawa force-pushed the fix-ast-estree-property branch from 25e33e6 to daa8c7d Compare February 9, 2025 03:05
@hi-ogawa hi-ogawa marked this pull request as ready for review February 9, 2025 03:15
@hi-ogawa hi-ogawa mentioned this pull request Feb 9, 2025
Open
@Boshen Boshen force-pushed the fix-ast-estree-property branch from daa8c7d to 517cb0e Compare February 9, 2025 04:20
@Boshen Boshen force-pushed the graphite-base/8974 branch from ac4457c to 7ddee17 Compare February 9, 2025 04:20
@Boshen Boshen changed the base branch from graphite-base/8974 to ast-estree-unary-prefix February 9, 2025 04:21
@Boshen Boshen force-pushed the fix-ast-estree-property branch from 517cb0e to 00859ef Compare February 9, 2025 04:21
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 9, 2025
@overlookmotel Graphite App
Copy link
Contributor

overlookmotel commented Feb 9, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Feb 9, 1:54 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 9, 1:55 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 9, 1:59 PM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #8973.
  • Feb 9, 1:59 PM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #8973.
  • Feb 9, 2:00 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 9, 2:00 PM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #8973.
  • Feb 9, 2:01 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 9, 2:51 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 9, 3:01 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 9, 3:05 PM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Feb 9, 2025
@overlookmotel overlookmotel force-pushed the ast-estree-unary-prefix branch from 7ddee17 to 47fd570 Compare February 9, 2025 19:00
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 9, 2025
@overlookmotel overlookmotel changed the base branch from ast-estree-unary-prefix to graphite-base/8974 February 9, 2025 19:45
@overlookmotel overlookmotel force-pushed the fix-ast-estree-property branch from 00859ef to 7050202 Compare February 9, 2025 19:50
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 9, 2025
@overlookmotel overlookmotel changed the base branch from graphite-base/8974 to main February 9, 2025 19:51
@overlookmotel overlookmotel force-pushed the fix-ast-estree-property branch from 7050202 to 4fe5295 Compare February 9, 2025 19:51
@hi-ogawa
fix(ast): estree compat Property (#8974)
2ee1d6c 
Part of #2854

```diff
-Positive Passed: 16040/44293 (36.21%)
+Positive Passed: 28924/44293 (65.30%)
```
@graphite-app graphite-app bot force-pushed the fix-ast-estree-property branch from 4fe5295 to 2ee1d6c Compare February 9, 2025 20:01
@graphite-app graphite-app bot merged commit 2ee1d6c into main Feb 9, 2025
25 checks passed
@graphite-app graphite-app bot deleted the fix-ast-estree-property branch February 9, 2025 20:05
Dunqing pushed a commit that referenced this pull request Feb 10, 2025
@hi-ogawa @Dunqing
fix(ast): estree compat Property (#8974)
4664ebd 
Part of #2854

```diff
-Positive Passed: 16040/44293 (36.21%)
+Positive Passed: 28924/44293 (65.30%)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hi-ogawa @overlookmotel