Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ast): estree compat CatchClause #8975

Merged
merged 1 commit into from
Feb 9, 2025
Merged

fix(ast): estree compat CatchClause #8975

merged 1 commit into from
Feb 9, 2025

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Feb 8, 2025 •
edited
Loading

Part of #2854

-Positive Passed: 28924/44293 (65.30%)
+Positive Passed: 30446/44293 (68.74%)

This was referenced Feb 8, 2025
Merged
Merged
Merged
@hi-ogawa Graphite App
Copy link
Contributor Author

hi-ogawa commented Feb 8, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hi-ogawa hi-ogawa changed the title fix: estree compat CatchClause fix(ast): estree compat CatchClause Feb 8, 2025
@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Feb 8, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 8, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8975 will not alter performance

Comparing fix-ast-CatchClause (9911dcf) with fix-ast-estree-property (00859ef)

Summary

✅ 33 untouched benchmarks

@hi-ogawa hi-ogawa mentioned this pull request Feb 8, 2025
Merged
@hi-ogawa hi-ogawa changed the base branch from fix-ast-estree-property to graphite-base/8975 February 8, 2025 07:21
@hi-ogawa hi-ogawa force-pushed the fix-ast-CatchClause branch from a2f5bd9 to e45f816 Compare February 8, 2025 07:23
@hi-ogawa hi-ogawa force-pushed the fix-ast-CatchClause branch from e45f816 to a601a15 Compare February 8, 2025 07:31
@github-actions github-actions bot added the A-ast-tools Area - AST tools label Feb 8, 2025
@hi-ogawa hi-ogawa force-pushed the fix-ast-CatchClause branch from 8545cac to 16d6b0a Compare February 9, 2025 02:38
@hi-ogawa hi-ogawa force-pushed the fix-ast-CatchClause branch from 16d6b0a to 4bd69c0 Compare February 9, 2025 03:07
@hi-ogawa hi-ogawa marked this pull request as ready for review February 9, 2025 03:15
@hi-ogawa hi-ogawa mentioned this pull request Feb 9, 2025
Merged
@Boshen Boshen force-pushed the fix-ast-CatchClause branch from 4bd69c0 to fdcbdad Compare February 9, 2025 04:21
@Boshen Boshen force-pushed the graphite-base/8975 branch from daa8c7d to 00859ef Compare February 9, 2025 04:21
@Boshen Boshen changed the base branch from graphite-base/8975 to fix-ast-estree-property February 9, 2025 04:22
@Boshen Boshen force-pushed the fix-ast-CatchClause branch from fdcbdad to 9911dcf Compare February 9, 2025 04:22
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 9, 2025
@overlookmotel Graphite App
Copy link
Contributor

overlookmotel commented Feb 9, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Feb 9, 1:59 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 9, 2:00 PM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #8973.
  • Feb 9, 2:01 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 9, 2:51 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 9, 3:01 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 9, 3:07 PM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 9, 2025
@overlookmotel
Copy link
Contributor

From 14% to 68% passing in 4 short PRs!

@overlookmotel overlookmotel force-pushed the fix-ast-estree-property branch 2 times, most recently from 7050202 to 4fe5295 Compare February 9, 2025 19:51
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 9, 2025
@hi-ogawa
fix(ast): estree compat CatchClause (#8975)
8eccdec 
Part of #2854

```diff
-Positive Passed: 28924/44293 (65.30%)
+Positive Passed: 30446/44293 (68.74%)
```
@graphite-app graphite-app bot force-pushed the fix-ast-estree-property branch from 4fe5295 to 2ee1d6c Compare February 9, 2025 20:01
@graphite-app graphite-app bot force-pushed the fix-ast-CatchClause branch from a0f1d6b to 8eccdec Compare February 9, 2025 20:01
Base automatically changed from fix-ast-estree-property to main February 9, 2025 20:05
@graphite-app graphite-app bot merged commit 8eccdec into main Feb 9, 2025
24 of 26 checks passed
@graphite-app graphite-app bot deleted the fix-ast-CatchClause branch February 9, 2025 20:07
Dunqing pushed a commit that referenced this pull request Feb 10, 2025
@hi-ogawa @Dunqing
fix(ast): estree compat CatchClause (#8975)
8a79de3 
Part of #2854

```diff
-Positive Passed: 28924/44293 (65.30%)
+Positive Passed: 30446/44293 (68.74%)
```
@oxc-bot oxc-bot mentioned this pull request Feb 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hi-ogawa @overlookmotel