Conversation
There was a problem hiding this comment.
@nicolasmccurdy looks good. does your validator prevent form submission?
There was a problem hiding this comment.
Oops, it doesn't. I'll fix that soon.
There was a problem hiding this comment.
I just realized that since the form method is #, this page shouldn't be making any actual network requests when you submit the form anyway. So if I'm understanding this correctly, the form already can't be submitted. Though I guess I could disable the button or do something similar.
There was a problem hiding this comment.
I just pushed a commit that disables the button whenever anything is invalid.
There was a problem hiding this comment.
Good stuff. The default behavior of form will attempt to post to the # action whatever it might be. Usually, you'll see use of .preventDefault here to prevent submission. The big concern here of course is reducing the number of calls to the server.
There was a problem hiding this comment.
Ah right, I forgot that you need to use that method for prevent form submission. Should I try that out, or is disabling the button good enough?
2 participants
No description provided.