-
Notifications
You must be signed in to change notification settings - Fork 30
Nick's solution #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nickserv
wants to merge
3
commits into
master
Choose a base branch
from
nicks-solution
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,53 @@ | ||
| // jQuery elements | ||
| var $email = $('form input[type=text]'); | ||
| var $password = $('form input[type=password]'); | ||
| var $submit = $('form input[type=submit]'); | ||
| var $errors = $('.errors li'); | ||
|
|
||
| //insert your code here | ||
|
|
||
| $(function(){ | ||
| // Form validators, matching to each of the four errors in order | ||
| var validators = [ | ||
| // Please enter a valid email address | ||
| function () { | ||
| return /^.+@.+\..+$/.test($email.val()); | ||
| }, | ||
|
|
||
| //insert your code here | ||
| // Your password should be at least 8 characters long | ||
| function () { | ||
| return $password.val().length >= 8; | ||
| }, | ||
|
|
||
| // Your password should contain at least one capital letter | ||
| function () { | ||
| return /[A-Z]/.test($password.val()); | ||
| }, | ||
|
|
||
| // Your password should contain at least one number (0-9) | ||
| function () { | ||
| return /\d/.test($password.val()); | ||
| } | ||
| ]; | ||
|
|
||
| // Hides all validation errors | ||
| function hideErrors() { | ||
| $errors.hide(); | ||
| $submit.prop('disabled', false); | ||
| } | ||
|
|
||
| // Runs all validators and display any errors that occur | ||
| function validate() { | ||
| hideErrors(); | ||
| validators.forEach(function (validator, index) { | ||
| if (!validator()) { | ||
| $errors.eq(index).show(); | ||
| $submit.prop('disabled', true); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| // Run validators initially and whenever an input is updated | ||
| $(function () { | ||
| hideErrors(); | ||
| validate(); | ||
| $email.on('keyup', validate); | ||
| $password.on('keyup', validate); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolasmccurdy looks good. does your validator prevent form submission?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, it doesn't. I'll fix that soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that since the form method is
#, this page shouldn't be making any actual network requests when you submit the form anyway. So if I'm understanding this correctly, the form already can't be submitted. Though I guess I could disable the button or do something similar.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed a commit that disables the button whenever anything is invalid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. The default behavior of form will attempt to post to the
#action whatever it might be. Usually, you'll see use of.preventDefaulthere to prevent submission. The big concern here of course is reducing the number of calls to the server.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, I forgot that you need to use that method for prevent form submission. Should I try that out, or is disabling the button good enough?